Skip to content

Conversation

mariusae
Copy link
Member

@mariusae mariusae commented Oct 7, 2025

Stack from ghstack (oldest at bottom):

In this change, we implement:

From<v1::ProcMeshRef> for ProcMesh

and

From<v1::ActorMeshRef<A>> for RootActorMesh<A>

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: D84081478

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Oct 7, 2025
In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!

ghstack-source-id: 314615484
Pull Request resolved: #1453
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 7, 2025
In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Oct 7, 2025
Pull Request resolved: #1453

In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!
ghstack-source-id: 314616752
In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Oct 7, 2025
Pull Request resolved: #1453

In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.
ghstack-source-id: 314644713

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!
In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Oct 8, 2025
Pull Request resolved: #1453

In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.
ghstack-source-id: 314840436

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!
In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Oct 8, 2025
Pull Request resolved: #1453

In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.
ghstack-source-id: 314854078

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!
In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!

[ghstack-poisoned]
In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!

[ghstack-poisoned]
In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!

[ghstack-poisoned]
In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!

[ghstack-poisoned]
In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!

[ghstack-poisoned]
In this change, we implement:

```
From<v1::ProcMeshRef> for ProcMesh
```

and

```
From<v1::ActorMeshRef<A>> for RootActorMesh<A>
```

This will allow us to temporarily use v1 instances through a v0 API, while we transition the usage sites.

Differential Revision: [D84081478](https://our.internmc.facebook.com/intern/diff/D84081478/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84081478/)!

[ghstack-poisoned]
Copy link

meta-codesync bot commented Oct 9, 2025

This pull request has been merged in 216f8bd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged meta-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants