Enable v1 native on test_python_actors #1460
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D83931993
Differential Revision: D83934172
Differential Revision: D83530618
Differential Revision: D83533433
Summary: Pull Request resolved: meta-pytorch#1350 Differential Revision: D83385432
Differential Revision: D83591305
Summary: Pull Request resolved: meta-pytorch#1304 This diff adds native v1 casting implementation, instead of piggybacking v0's implementation. Specifically, this diff: 1. Add V1 handlers in comm actors, i.e. `CastMessageV1` and `ForwardMessageV1`. 2. On the v1 ActorMesh side, use `Sequencers` to generate seq numbers, and send to comm actors through `CastMessageV1`. 3. Update several direct send call sites to use `ActorRef::seq_send`, so seq numbers are always assigned. Note that we still need to wait for all `&impl cap::CanSend` callsites to be updated with `&impl context::Actor` before we can turn on the native v1 casting in production, since we need to ensure all `direct send`s are also getting the sequence number assigned. Differential Revision: D82537988
meta-cla
bot
added
the
CLA Signed
Differential Revision: D83839619
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Oct 8, 2025
Summary: Pull Request resolved: meta-pytorch#1460 This diff enables the native v1 multicasting added in this stack for the python tests in `test_python_actors`. Differential Revision: D83838109
pzhan9
force-pushed
the
export-D83838109
branch
from
41b2f20 to
b8fbe87
Compare
Summary: Pull Request resolved: meta-pytorch#1460 This diff enables the native v1 multicasting added in this stack for the python tests in `test_python_actors`. Differential Revision: D83838109
pzhan9
force-pushed
the
export-D83838109
branch
from
b8fbe87 to
8578151
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D83838109