[monarch] monarch.enable_transport(), and v1 controllers #1462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff does two things: - Introduce `monarch.enable_transport(...)`, which enables the user to set the transport of the root client. For now, only one transport is allowed. It must be called before any other monarch APIs, and it will throw if called multiple times with different transports. - Enable controllers in v1 Differential Revision: [D84100520](https://our.internmc.facebook.com/intern/diff/D84100520/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84100520/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 7, 2025
This diff does two things: - Introduce `monarch.enable_transport(...)`, which enables the user to set the transport of the root client. For now, only one transport is allowed. It must be called before any other monarch APIs, and it will throw if called multiple times with different transports. - Enable controllers in v1 Differential Revision: [D84100520](https://our.internmc.facebook.com/intern/diff/D84100520/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84100520/)! ghstack-source-id: 314695237 Pull Request resolved: #1462
meta-cla
bot
added
the
CLA Signed
This diff does two things: - Introduce `monarch.enable_transport(...)`, which enables the user to set the transport of the root client. For now, only one transport is allowed. It must be called before any other monarch APIs, and it will throw if called multiple times with different transports. - Enable controllers in v1 Differential Revision: [D84100520](https://our.internmc.facebook.com/intern/diff/D84100520/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84100520/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 8, 2025
Pull Request resolved: #1462 This diff does two things: - Introduce `monarch.enable_transport(...)`, which enables the user to set the transport of the root client. For now, only one transport is allowed. It must be called before any other monarch APIs, and it will throw if called multiple times with different transports. - Enable controllers in v1 ghstack-source-id: 314719319 Differential Revision: [D84100520](https://our.internmc.facebook.com/intern/diff/D84100520/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84100520/)!
|
This pull request has been merged in 6ca383a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
this_hostfor v1 to only return a single host instead of the whole host mesh #1459This diff does two things:
monarch.enable_transport(...), which enables the user to set the transport of the root client. For now, only one transport is allowed. It must be called before any other monarch APIs, and it will throw if called multiple times with different transports.Differential Revision: D84100520
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!