[monarch] envvar to force v1 by default #1463
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having monarch.actor selectively import from the same parts. This fixes the public API. Internal uses will probably need to call the add create_host_mesh_from_alloc which will give the right kind of host mesh based on environment variable. `MONARCH_HOST_MESH_V1_REMOVE_ME_BEFORE_RELEASE` is the name of the flag. Chosen because this needs to be gone before the public release. Differential Revision: [D84107651](https://our.internmc.facebook.com/intern/diff/D84107651/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84107651/)! [ghstack-poisoned]
This was referenced Oct 7, 2025
Closed
zdevito
added a commit
that referenced
this pull request
Oct 7, 2025
Having monarch.actor selectively import from the same parts. This fixes the public API. Internal uses will probably need to call the add create_host_mesh_from_alloc which will give the right kind of host mesh based on environment variable. `MONARCH_HOST_MESH_V1_REMOVE_ME_BEFORE_RELEASE` is the name of the flag. Chosen because this needs to be gone before the public release. Differential Revision: [D84107651](https://our.internmc.facebook.com/intern/diff/D84107651/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84107651/)! ghstack-source-id: 314700169 Pull Request resolved: #1463
meta-cla
bot
added
the
CLA Signed
Having monarch.actor selectively import from the same parts. This fixes the public API. Internal uses will probably need to call the add create_host_mesh_from_alloc which will give the right kind of host mesh based on environment variable. `MONARCH_HOST_MESH_V1_REMOVE_ME_BEFORE_RELEASE` is the name of the flag. Chosen because this needs to be gone before the public release. Differential Revision: [D84107651](https://our.internmc.facebook.com/intern/diff/D84107651/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84107651/)! [ghstack-poisoned]
This was referenced Oct 7, 2025
Closed
Closed
zdevito
added a commit
that referenced
this pull request
Oct 8, 2025
Pull Request resolved: #1463 Having monarch.actor selectively import from the same parts. This fixes the public API. Internal uses will probably need to call the add create_host_mesh_from_alloc which will give the right kind of host mesh based on environment variable. `MONARCH_HOST_MESH_V1_REMOVE_ME_BEFORE_RELEASE` is the name of the flag. Chosen because this needs to be gone before the public release. Differential Revision: [D84107651](https://our.internmc.facebook.com/intern/diff/D84107651/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84107651/)! ghstack-source-id: 314898148
Open
|
This pull request has been merged in cd0e0e3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Having monarch.actor selectively import from the same parts. This fixes the public API. Internal uses will probably need to call the add create_host_mesh_from_alloc which will give the right kind of host mesh based on environment variable.
MONARCH_HOST_MESH_V1_REMOVE_ME_BEFORE_RELEASEis the name of the flag. Chosen because this needs to be gone before the public release.Differential Revision: D84107651
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!