Remove legacy support of device='cuda:0:beta'
#965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
commented
Oct 15, 2025
| # TODONVDEC P2: remove support for this everywhere. This will require | ||
| # updating our tests. | ||
| if device == "cuda:0:beta": | ||
| device = "cuda:0" |
Contributor
Author
There was a problem hiding this comment.
This is the actual removal. Everything else in this PR is a consequence of that change - mostly just changing how we use the BETA backend in existing tests.
scotts
reviewed
Oct 15, 2025
test/utils.py
Outdated
| return device_str, "default" | ||
|
|
||
|
|
||
| def make_video_decoder(*args, **kwargs) -> Union[VideoDecoder, str]: |
Contributor
There was a problem hiding this comment.
Return type is supposed to be a Tuple not Union, correct?
scotts
approved these changes
Oct 15, 2025
Contributor
scotts
left a comment
scotts
left a comment
There was a problem hiding this comment.
I think we need to fix the return type of make_video_decoder, but otherwise this is great!
NicolasHug
added a commit
to NicolasHug/torchcodec
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.