Skip to content

Remove legacy support of device='cuda:0:beta' #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasHug merged 3 commits into from
Oct 16, 2025
Merged

Remove legacy support of device='cuda:0:beta' #965

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e358d5b
Remove legacy support of device='cuda:0:beta'
NicolasHug Oct 15, 2025
c86b16d
Merge branch 'main' of github.com:pytorch/torchcodec into removelegacy
NicolasHug Oct 15, 2025
98095df
Fix return type
NicolasHug Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/torchcodec/decoders/_video_decoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,6 @@ def __init__(
# TODONVDEC P2 rename 'default' into 'ffmpeg' everywhere.
device_variant = "default"

# Legacy support for device="cuda:0:beta" syntax
# TODONVDEC P2: remove support for this everywhere. This will require
# updating our tests.
if device == "cuda:0:beta":
device = "cuda:0"
Copy link
Contributor Author

@NicolasHug NicolasHug Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual removal. Everything else in this PR is a consequence of that change - mostly just changing how we use the BETA backend in existing tests.

device_variant = "beta"

core.add_video_stream(
self._decoder,
stream_index=stream_index,
Expand Down
Loading
Loading