Skip to content

Conversation

vidhyav
Copy link
Contributor

@vidhyav vidhyav commented Sep 18, 2025

Rithesh's pr commandeered: #157

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 18, 2025
@allenwang28
Copy link
Contributor

Can we do this incrementally? Let's start a PR that integrates completion and experience, with Experience renamed to Episode (consistent with what we have now)

I want that, plus the ability to convert from e.g. vLLM native outputs to our Forge native outputs.

An example from GRPO main: https://github.com/meta-pytorch/forge/blob/main/apps/grpo/main.py#L311-L313, we should be able to convert from the vLLM request to a forge.data_types.CompletionOutput, then create an Episode from only forge native data types. Ideally like:

responses = await policy.generate.choose(prompt)
completions = forge.data_type.CompletionOutput.from_vllm(responses)

etc.

@vidhyav
Copy link
Contributor Author

vidhyav commented Sep 19, 2025

Huh this was a set of stacked diffs and it is painful to commandeer AND modify. I am going to simply restart a new diff. SIGH.

@vidhyav vidhyav closed this Sep 19, 2025
@vidhyav vidhyav mentioned this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants