Skip to content

Conversation

Jack-Khuu
Copy link
Contributor

The main change is moving forge.actors._torchstore_utils to forge.util._torchstore

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 15, 2025
@Jack-Khuu Jack-Khuu changed the title Move torchstore_utils from actors to utils Move torchstore_utils from actors/ to util/ Oct 15, 2025
@Jack-Khuu Jack-Khuu changed the title Move torchstore_utils from actors/ to util/ Move torchstore_utils from actor/ to util/ Oct 15, 2025
@casteryh
Copy link
Contributor

@joecummings wanted this to be moved into apps/ (see #292 (comment))

@joecummings
Copy link
Member

joecummings commented Oct 15, 2025

@joecummings wanted this to be moved into apps/ (see #292 (comment))

oh wow, I must've been super out of it. I meant src/ :)

But yeah - @casteryh was taking a look at this. Idc who pushes this over the finish line, but please coordinate and take feedback from that PR as well.

@Jack-Khuu
Copy link
Contributor Author

oh wow, I must've been super out of it. I meant src/ :)

Great minds think alike

please coordinate and take feedback from that PR as well.

@casteryh wanna merge this into your branch? Or we land this and rebase your PR on top?

No prefernece

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.53%. Comparing base (633b219) to head (cf5dab5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   64.69%   73.53%   +8.84%     
==========================================
  Files          79       81       +2     
  Lines        7775     7818      +43     
==========================================
+ Hits         5030     5749     +719     
+ Misses       2745     2069     -676     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@casteryh
Copy link
Contributor

oh wow, I must've been super out of it. I meant src/ :)

Great minds think alike

please coordinate and take feedback from that PR as well.

@casteryh wanna merge this into your branch? Or we land this and rebase your PR on top?

No prefernece

Lemme merge you branch

@Jack-Khuu Jack-Khuu changed the title Move torchstore_utils from actor/ to util/ [NOT TO LAND] Move torchstore_utils from actor/ to util/ Oct 16, 2025
@Jack-Khuu
Copy link
Contributor Author

Sounds good, I'll leave the PR/branch here

Feel free to close when you merge in

@Jack-Khuu Jack-Khuu added the NOT_FOR_REVIEW PR's from Core Maintainers, not intended for review or landing label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. NOT_FOR_REVIEW PR's from Core Maintainers, not intended for review or landing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants