-
Notifications
You must be signed in to change notification settings - Fork 16
[NOT TO LAND] Move torchstore_utils from actor/ to util/ #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@joecummings wanted this to be moved into |
oh wow, I must've been super out of it. I meant src/ :) But yeah - @casteryh was taking a look at this. Idc who pushes this over the finish line, but please coordinate and take feedback from that PR as well. |
Great minds think alike
@casteryh wanna merge this into your branch? Or we land this and rebase your PR on top? No prefernece |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
+ Coverage 64.69% 73.53% +8.84%
==========================================
Files 79 81 +2
Lines 7775 7818 +43
==========================================
+ Hits 5030 5749 +719
+ Misses 2745 2069 -676 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lemme merge you branch |
Sounds good, I'll leave the PR/branch here Feel free to close when you merge in |
The main change is moving
forge.actors._torchstore_utils
toforge.util._torchstore