Consolidate on install.sh, move to stable packages #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
joecummings
reviewed
Oct 21, 2025
assets/versions.sh
Outdated
| PYTORCH_VERSION="2.9.0" | ||
|
|
||
| # vLLM branch | ||
| VLLM_BRANCH="v0.10.0" |
There was a problem hiding this comment.
Can we change these to point to monarch stable, torchtitan stable and torchstore stable
There was a problem hiding this comment.
Yeah right now I have them hardcoded. But good point. Honestly I need to see where else these versions are used.. there's a world where we just delete this file entirely to reduce indirection
| } | ||
|
|
||
| # Install required system packages | ||
| install_system_packages() { |
There was a problem hiding this comment.
We don't need this anymore?
There was a problem hiding this comment.
Idk maybe we do, just trying it out
There was a problem hiding this comment.
brought it back just for safety
This reverts commit 4d2a103.
joecummings
reviewed
Oct 22, 2025
.github/workflows/unit_test.yaml
Outdated
There was a problem hiding this comment.
These won't work b/c u need a GPU runner
There was a problem hiding this comment.
wait why? they were working before, no?
allenwang28
approved these changes
Oct 22, 2025
photomz
pushed a commit
to photomz/forge
that referenced
this pull request
Oct 25, 2025
Co-authored-by: joecummings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested via:
Also working on green CI