-
Notifications
You must be signed in to change notification settings - Fork 49
Consolidate on install.sh, move to stable packages #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 29 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
3abb3e8
enable vLLM upload with CUDA 12.8 build
ebsmothers 48a11a5
install stable torch
ebsmothers 395c1ab
copy vllm_reqs.txt from joe's pr
ebsmothers f0878f7
remove nightly index path
ebsmothers 994b400
Merge branch 'main' into cuda-128
ebsmothers 85421b5
use install script in GHA workflows
ebsmothers fa02756
move to install script
ebsmothers b370d97
update vLLM requirements files
ebsmothers 4d2a103
[testing] run unit test on 3.10 only
ebsmothers ffdaa52
Revert "[testing] run unit test on 3.10 only"
ebsmothers f9a6620
wip changes
ebsmothers 80462a1
Merge branch 'main' into cuda-128
ebsmothers 5f260eb
comments
ebsmothers be0069a
remove unused wheels
ebsmothers 6af94cd
more cleanup
ebsmothers 9eb1bc1
update versions
ebsmothers 4044dc1
simplify things
ebsmothers 7a26f8a
revert docs changes
ebsmothers 6c65fad
update requirements and script
ebsmothers e55e235
one more try
ebsmothers 4ab4caf
try python 3.11
ebsmothers 67a18c0
run only on 310
joecummings 100f584
Comment out hopefully unnecessary parts of build
joecummings d10a8c9
You need a GPU runner to run stuff
joecummings 95c2f25
Install six
joecummings c9b2a62
Simplify docs build
joecummings 27f77df
setuptools < 80
joecummings 0995062
ugh, quote it
joecummings 49be5a1
Use py 312 in main ex
joecummings 008fad8
Remove build refernce
joecummings dc79ad8
delete cpu unit test workflow
ebsmothers bb15ede
typo fix
ebsmothers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,44 @@ | ||
| name: Unit Tests | ||
| # name: Unit Tests | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [ main ] | ||
| workflow_dispatch: | ||
| # on: | ||
| # pull_request: | ||
| # push: | ||
| # branches: [ main ] | ||
| # workflow_dispatch: | ||
|
|
||
| jobs: | ||
| unit_tests: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
| strategy: | ||
| matrix: | ||
| python-version: ['3.10', '3.11', '3.12'] | ||
| steps: | ||
| - name: Check out repo | ||
| uses: actions/checkout@v4 | ||
| - name: Setup conda env | ||
| uses: conda-incubator/setup-miniconda@v2 | ||
| with: | ||
| auto-update-conda: true | ||
| miniconda-version: "latest" | ||
| activate-environment: test | ||
| python-version: ${{ matrix.python-version }} | ||
| - name: Update pip | ||
| run: python -m pip install --upgrade pip | ||
| - name: Install pytorch | ||
| run: python -m pip install torch==2.9.0.dev20250826 --extra-index-url https://download.pytorch.org/whl/nightly/cpu | ||
| - name: Install monarch | ||
| run: pip install assets/ci/monarch_no_torch-0.1.0.dev20251010-py3-none-any.whl | ||
| - name: Install torchstore | ||
| run: pip install assets/wheels/torchstore-0.1.0-py3-none-any.whl | ||
| - name: Install torchtitan | ||
| run: | | ||
| pip install assets/wheels/torchtitan-0.1.0-py3-none-any.whl | ||
| pip install tyro | ||
| - name: Install dependencies | ||
| run: python -m pip install --no-build-isolation -e ".[dev]" | ||
| - name: Run unit tests with coverage | ||
| # TODO add all tests | ||
| run: pytest tests/unit_tests --cov=. --cov-report=xml --durations=20 -vv | ||
| - name: Upload Coverage to Codecov | ||
| uses: codecov/codecov-action@v3 | ||
| # jobs: | ||
| # unit_tests: | ||
| # runs-on: ubuntu-latest | ||
| # timeout-minutes: 15 | ||
| # strategy: | ||
| # matrix: | ||
| # python-version: ['3.10'] | ||
| # steps: | ||
| # - name: Check out repo | ||
| # uses: actions/checkout@v4 | ||
| # with: | ||
| # fetch-depth: 0 | ||
| # - name: Setup conda env | ||
| # uses: conda-incubator/setup-miniconda@v2 | ||
| # with: | ||
| # auto-update-conda: true | ||
| # miniconda-version: "latest" | ||
| # activate-environment: test | ||
| # python-version: '3.10' | ||
| # auto-activate: false | ||
| # - name: Verify conda environment | ||
| # shell: bash -l {0} | ||
| # run: | | ||
| # conda info | ||
| # which python | ||
| # which conda | ||
| # - name: Update pip | ||
| # shell: bash -l {0} | ||
| # run: python -m pip install --upgrade pip | ||
| # - name: Install torchforge | ||
| # run: ./scripts/install.sh | ||
| # - name: Run unit tests with coverage | ||
| # # TODO add all tests | ||
| # run: pytest tests/unit_tests --cov=. --cov-report=xml --durations=20 -vv | ||
| # - name: Upload Coverage to Codecov | ||
| # uses: codecov/codecov-action@v3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These won't work b/c u need a GPU runner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait why? they were working before, no?