Skip to content

Conversation

@haarg
Copy link
Member

@haarg haarg commented Jun 1, 2025

On older deployments, the xslate cache would sometimes not correctly
detect new template files, leading to unpredictable errors. Purging of
the cache directory on startup was added to deal with this.

The normal deployment is now done with a docker container, so there is
nothing to clear out at startup. Additionally, the cache directory isn't
being configured to a static path, so it will always be using a newly
created temp directory. Clearing out the template cache is no longer
relevant, so it can be removed.

haarg added 2 commits June 1, 2025 15:45
On older deployments, the xslate cache would sometimes not correctly
detect new template files, leading to unpredictable errors. Purging of
the cache directory on startup was added to deal with this.

The normal deployment is now done with a docker container, so there is
nothing to clear out at startup. Additionally, the cache directory isn't
being configured to a static path, so it will always be using a newly
created temp directory. Clearing out the template cache is no longer
relevant, so it can be removed.
@codecov
Copy link

codecov bot commented Jun 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.36%. Comparing base (29f566b) to head (ec54730).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3366      +/-   ##
==========================================
- Coverage   73.41%   73.36%   -0.06%     
==========================================
  Files          68       68              
  Lines        2389     2388       -1     
  Branches      335      335              
==========================================
- Hits         1754     1752       -2     
- Misses        507      508       +1     
  Partials      128      128              
Files with missing lines Coverage Δ
lib/MetaCPAN/Web/View/Xslate.pm 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@haarg haarg requested a review from oalders June 3, 2025 18:44
@haarg haarg enabled auto-merge June 3, 2025 18:44
@haarg haarg added this pull request to the merge queue Jun 3, 2025
Merged via the queue into master with commit 2d2c67c Jun 3, 2025
12 checks passed
@haarg haarg deleted the haarg/xslate-no-remove-cache branch June 3, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants