Skip to content

xslate: don't try to remove cache dir #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

xslate: don't try to remove cache dir #3366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32cbdff
xslate: don't try to remove cache dir
haarg Mar 5, 2025
ec54730
use Path::Tiny to generate temp dir for xslate
haarg Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions lib/MetaCPAN/Web/View/Xslate.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
package MetaCPAN::Web::View::Xslate;
use Moose;
extends qw(Catalyst::View::Xslate);
use File::Path ();
use File::Temp ();
use Path::Tiny ();
use MetaCPAN::Web::Types qw( AbsPath );

has '+syntax' => ( default => 'Metakolon' );
Expand All @@ -13,11 +12,7 @@ has '+cache_dir' => (
isa => AbsPath,
coerce => 1,
default => sub {
File::Temp::tempdir(
TEMPLATE => 'metacpan-web-templates-XXXXXX',
CLEANUP => 1,
TMPDIR => 1,
);
Path::Tiny->tempdir( TEMPLATE => 'metacpan-web-templates-XXXXXX' );
},
);
has '+module' => (
Expand Down Expand Up @@ -48,16 +43,6 @@ sub COMPONENT {
return $class->SUPER::COMPONENT( $app, $args );
}

around preload_templates => sub {
my ( $orig, $self ) = ( shift, shift );

if ( my $cache_dir = $self->xslate->{cache_dir} ) {
File::Path::rmtree($cache_dir);
}

$self->$orig(@_);
};

has '+expose_methods' => (
default =>
sub
Expand Down
Loading