Conversation
637c2ef to
3da58e2
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
codetracer/src/ct/trace/run.nim
Lines 62 to 63 in b53a943
ct on PATH
When the binaries are built for the Python wheel, codetracerExe is compiled as the plain string "ct" rather than an absolute path. The restart branch here still launches startProcess with only {poParentStreams}, so the Nim runtime tries to execute a relative file and fails with OSError: no such file on installations that rely on PATH lookup (the newly added Python package). Other call sites were updated to pass poUsePath for this exact scenario. Add poUsePath (or resolve an absolute path) so the replay restart works in wheel-based deployments.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
we can do that, but the "restart" exit code-based feature is mostly an internal thing for easier testing of some things that we made for Franz in the past; maybe we should not compile it for production/user builds now, especially if @SersemPeca adds a more advanced "rerun" functionality in a different way to ct |
| @@ -0,0 +1,45 @@ | |||
| [metadata] | |||
| name = codetracer | |||
| version = 25.9.2 | |||
There was a problem hiding this comment.
do we want this version schema(calendar) for pip? probably yes, but to make sure?
No description provided.