Skip to content

Pip package for ct utility#419

Merged
alehander92 merged 10 commits intomainfrom
build-pip
Oct 28, 2025
Merged

Pip package for ct utility#419
alehander92 merged 10 commits intomainfrom
build-pip

Conversation

@Ro6afF
Copy link
Contributor

@Ro6afF Ro6afF commented Oct 21, 2025

No description provided.

@alehander92 alehander92 added enhancement New feature or request packaging Any issue that has come from a specific package or distribution scheme ct-entrypoint Issues related to the ct utility labels Oct 21, 2025
@Ro6afF Ro6afF force-pushed the build-pip branch 12 times, most recently from 637c2ef to 3da58e2 Compare October 27, 2025 11:15
@Ro6afF Ro6afF self-assigned this Oct 27, 2025
@tzanko-matev
Copy link
Contributor

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

let process = startProcess(codetracerExe, args = @["replay", fmt"--id={recordedTrace.id}"], options = {poParentStreams})
waitForExit(process) == RESTART_EXIT_CODE

P1 Badge Allow restart subprocess to search ct on PATH

When the binaries are built for the Python wheel, codetracerExe is compiled as the plain string "ct" rather than an absolute path. The restart branch here still launches startProcess with only {poParentStreams}, so the Nim runtime tries to execute a relative file and fails with OSError: no such file on installations that rely on PATH lookup (the newly added Python package). Other call sites were updated to pass poUsePath for this exact scenario. Add poUsePath (or resolve an absolute path) so the replay restart works in wheel-based deployments.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@alehander92
Copy link
Contributor

we can do that, but the "restart" exit code-based feature is mostly an internal thing for easier testing of some things that we made for Franz in the past; maybe we should not compile it for production/user builds now, especially if @SersemPeca adds a more advanced "rerun" functionality in a different way to ct

@@ -0,0 +1,45 @@
[metadata]
name = codetracer
version = 25.9.2
Copy link
Contributor

@alehander92 alehander92 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want this version schema(calendar) for pip? probably yes, but to make sure?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fine

@alehander92 alehander92 merged commit 8ab7146 into main Oct 28, 2025
130 of 135 checks passed
@alehander92 alehander92 deleted the build-pip branch October 28, 2025 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ct-entrypoint Issues related to the ct utility enhancement New feature or request packaging Any issue that has come from a specific package or distribution scheme

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants