-
Notifications
You must be signed in to change notification settings - Fork 20
Removed subtuitionGroup for some gmx schema. Add labels #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.4.x
Are you sure you want to change the base?
Removed subtuitionGroup for some gmx schema. Add labels #424
Conversation
….section.schema.refinement
| </xs:complexType> | ||
| <!-- ........................................................................ --> | ||
| <xs:element name="ML_CompoundCRS" type="gmx:ML_CompoundCRS_Type" substitutionGroup="gml:CompoundCRS"/> | ||
| <xs:element name="ML_CompoundCRS" type="gmx:ML_CompoundCRS_Type"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema cannot be changed. It is part of a standard and the only way the schema can be changes is if the standard is changed. So generally, no files in the schema folder can be changed unless there is an obvious issue with the implementation of the standard.
The source for the schema file is here
https://schemas.metadata.geo.ca/metadata/tools/schemas/metadata/can-cgsb-171.100-2009-a/gmx/crsItem.xsd
And older reference here
https://nap.geogratis.gc.ca/metadata/tools/schemas/metadata/can-cgsb-171.100-2009-a/gmx/crsItem.xsd
And it is based on the iso19139 2007
https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19139/src/main/plugin/iso19139/schema/gmx/crsItem.xsd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if so, for example, the gml:baseUnit and gmx:baseUnit as I can see are like duplicated label and they look like to be meant for the same thing. I guess it's ok for this scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I mentioned obvious issues above, I did not mean obvious issues with the standard. I meant obvious issues with the implementation of the standard in the HNAP implementation.
You seem to be raising issues with the standard and we cannot change that.
I don't believe there are exceptions to changing the schema. Otherwise anyone who gets an NAP metadata record will not be able to properly validate the schema against the standard NAP schema. Sorry but we need to follow the standard schema as it is documented - even if it has issues.
|
@wangf1122 maybe try https://github.com/metadata101/iso19139.ca.HNAP/blob/4.4.x/src/main/plugin/iso19139.ca.HNAP/schema-substitutes.xml instead of changing the xsd. I have never used it, but it seems intended to limit the substitutes offered by the metadata editor. |
|
I had looked this file. It seems can only solve the issue of "gmd:MD_ScopeCode". But others. But the other name is still showing. |
|
@wangf1122 I tried the following: <field name="gml:UnitDefinition">
<substitute name="gml:BaseUnit"/>
<substitute name="gml:ConventionalUnit"/>
<substitute name="gml:DerivedUnit"/>
<substitute name="gml:UnitDefinition" />
</field>but it doesn't show up the
|
|
I made a separated pull request (#447) just to address the md_scope issue. Maybe we can get that change in first? |



In the advanced view, there are a few labels missing for the data quality section. Also some substitutional schema popped out. For example, gmd:level only have gmd:MD_ScopeCode
But gmx:MX_ScopeCode is also showing.

So of the xsd change to get the substitutionGroup removed. Also added couple of missing labels for
and