Skip to content

Removed subtuitionGroup for some gmx schema. Add labels #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangf1122 wants to merge 3 commits into
base: 4.4.x
Choose a base branch
from
Open

Removed subtuitionGroup for some gmx schema. Add labels #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eaad795
Removed subtuitionGroup for some gmx schema. Add label for Vertical C…
Feb 19, 2025
c5a538b
update french label
Feb 27, 2025
f2ffd6d
Merge remote-tracking branch 'upstream/4.4.x' into 4.2.x.data.quality…
Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions src/main/plugin/iso19139.ca.HNAP/loc/eng/labels.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2300,6 +2300,54 @@
<label>Projected CRS</label>
<description/>
</element>
<element name="gml:CompoundCRS">
<label>Compound CRS</label>
<description/>
</element>
<element name="gml:DerivedCRS">
<label>Derived CRS</label>
<description/>
</element>
<element name="gml:EngineeringCRS">
<label>Engineering CRS</label>
<description/>
</element>
<element name="gml:GeocentricCRS">
<label>Geocentric CRS</label>
<description/>
</element>
<element name="gml:GeodeticCRS">
<label>Geodetic CRS</label>
<description/>
</element>
<element name="gml:GeographicCRS">
<label>Geographic CRS</label>
<description/>
</element>
<element name="gml:ImageCRS">
<label>Image CRS</label>
<description/>
</element>
<element name="gml:TemporalCRS">
<label>Temporal CRS</label>
<description/>
</element>
<element name="gml:BaseUnit">
<label>Base Unit</label>
<description/>
</element>
<element name="gml:ConventionalUnit">
<label>Conventional Unit</label>
<description/>
</element>
<element name="gml:DerivedUnit">
<label>Derived Unit</label>
<description/>
</element>
<element name="gml:UnitDefinition">
<label>Unit Definition</label>
<description/>
</element>

<element name="gml:id">
<label>Identifier</label>
Expand Down
52 changes: 52 additions & 0 deletions src/main/plugin/iso19139.ca.HNAP/loc/fre/labels.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3658,6 +3658,58 @@
<label>CRS vertical</label>
<description>Information sur l'origine depuis laquelle les altitudes maximale et minimale ont été mesurées</description>
</element>
<element name="gml:ProjectedCRS">
<label>SRC Projeté</label>
<description/>
</element>
<element name="gml:CompoundCRS">
<label>SRC Composé</label>
<description/>
</element>
<element name="gml:DerivedCRS">
<label>SRC Dérivé</label>
<description/>
</element>
<element name="gml:EngineeringCRS">
<label>SRC Ingénierie</label>
<description/>
</element>
<element name="gml:GeocentricCRS">
<label>SRC Géocentrique</label>
<description/>
</element>
<element name="gml:GeodeticCRS">
<label>SRC Géodésique</label>
<description/>
</element>
<element name="gml:GeographicCRS">
<label>SRC Géographique</label>
<description/>
</element>
<element name="gml:ImageCRS">
<label>SRC Image</label>
<description/>
</element>
<element name="gml:TemporalCRS">
<label>SRC Temporel</label>
<description/>
</element>
<element name="gml:BaseUnit">
<label>Unité de base</label>
<description/>
</element>
<element name="gml:ConventionalUnit">
<label>Unité conventionnelle</label>
<description/>
</element>
<element name="gml:DerivedUnit">
<label>Unité dérivée</label>
<description/>
</element>
<element name="gml:UnitDefinition">
<label>Définition de l'unité</label>
<description/>
</element>
<element name="gmx:FileName">
<label>Nom du fichier</label>
<description>Nom du fichier et URL.</description>
Expand Down
16 changes: 8 additions & 8 deletions src/main/plugin/iso19139.ca.HNAP/schema/gmx/crsItem.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
</xs:complexContent>
</xs:complexType>
<!-- ........................................................................ -->
<xs:element name="ML_CompoundCRS" type="gmx:ML_CompoundCRS_Type" substitutionGroup="gml:CompoundCRS"/>
<xs:element name="ML_CompoundCRS" type="gmx:ML_CompoundCRS_Type"/>
Copy link
Contributor

@ianwallen ianwallen Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema cannot be changed. It is part of a standard and the only way the schema can be changes is if the standard is changed. So generally, no files in the schema folder can be changed unless there is an obvious issue with the implementation of the standard.

The source for the schema file is here
https://schemas.metadata.geo.ca/metadata/tools/schemas/metadata/can-cgsb-171.100-2009-a/gmx/crsItem.xsd
And older reference here
https://nap.geogratis.gc.ca/metadata/tools/schemas/metadata/can-cgsb-171.100-2009-a/gmx/crsItem.xsd
And it is based on the iso19139 2007
https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19139/src/main/plugin/iso19139/schema/gmx/crsItem.xsd

Copy link
Contributor Author

@wangf1122 wangf1122 Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if so, for example, the gml:baseUnit and gmx:baseUnit as I can see are like duplicated label and they look like to be meant for the same thing. I guess it's ok for this scenario?

Copy link
Contributor

@ianwallen ianwallen Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I mentioned obvious issues above, I did not mean obvious issues with the standard. I meant obvious issues with the implementation of the standard in the HNAP implementation.
You seem to be raising issues with the standard and we cannot change that.

I don't believe there are exceptions to changing the schema. Otherwise anyone who gets an NAP metadata record will not be able to properly validate the schema against the standard NAP schema. Sorry but we need to follow the standard schema as it is documented - even if it has issues.

<!-- ........................................................................ -->
<xs:complexType name="ML_CompoundCRS_PropertyType">
<xs:sequence minOccurs="0">
Expand Down Expand Up @@ -175,7 +175,7 @@
</xs:complexContent>
</xs:complexType>
<!-- ........................................................................ -->
<xs:element name="ML_GeodeticCRS" type="gmx:ML_GeodeticCRS_Type" substitutionGroup="gml:GeodeticCRS"/>
<xs:element name="ML_GeodeticCRS" type="gmx:ML_GeodeticCRS_Type"/>
<!-- ........................................................................ -->
<xs:complexType name="ML_GeodeticCRS_PropertyType">
<xs:sequence minOccurs="0">
Expand All @@ -195,7 +195,7 @@
</xs:complexContent>
</xs:complexType>
<!-- ........................................................................ -->
<xs:element name="ML_EngineeringCRS" type="gmx:ML_EngineeringCRS_Type" substitutionGroup="gml:EngineeringCRS"/>
<xs:element name="ML_EngineeringCRS" type="gmx:ML_EngineeringCRS_Type"/>
<!-- ........................................................................ -->
<xs:complexType name="ML_EngineeringCRS_PropertyType">
<xs:sequence minOccurs="0">
Expand All @@ -215,7 +215,7 @@
</xs:complexContent>
</xs:complexType>
<!-- ........................................................................ -->
<xs:element name="ML_VerticalCRS" type="gmx:ML_VerticalCRS_Type" substitutionGroup="gml:VerticalCRS"/>
<xs:element name="ML_VerticalCRS" type="gmx:ML_VerticalCRS_Type"/>
<!-- ........................................................................ -->
<xs:complexType name="ML_VerticalCRS_PropertyType">
<xs:sequence minOccurs="0">
Expand All @@ -235,7 +235,7 @@
</xs:complexContent>
</xs:complexType>
<!-- ........................................................................ -->
<xs:element name="ML_TemporalCRS" type="gmx:ML_TemporalCRS_Type" substitutionGroup="gml:TemporalCRS"/>
<xs:element name="ML_TemporalCRS" type="gmx:ML_TemporalCRS_Type"/>
<!-- ........................................................................ -->
<xs:complexType name="ML_TemporalCRS_PropertyType">
<xs:sequence minOccurs="0">
Expand All @@ -255,7 +255,7 @@
</xs:complexContent>
</xs:complexType>
<!-- ........................................................................ -->
<xs:element name="ML_ImageCRS" type="gmx:ML_ImageCRS_Type" substitutionGroup="gml:ImageCRS"/>
<xs:element name="ML_ImageCRS" type="gmx:ML_ImageCRS_Type"/>
<!-- ........................................................................ -->
<xs:complexType name="ML_ImageCRS_PropertyType">
<xs:sequence minOccurs="0">
Expand All @@ -275,7 +275,7 @@
</xs:complexContent>
</xs:complexType>
<!-- ........................................................................ -->
<xs:element name="ML_ProjectedCRS" type="gmx:ML_ProjectedCRS_Type" substitutionGroup="gml:ProjectedCRS"/>
<xs:element name="ML_ProjectedCRS" type="gmx:ML_ProjectedCRS_Type"/>
<!-- ........................................................................ -->
<xs:complexType name="ML_ProjectedCRS_PropertyType">
<xs:sequence minOccurs="0">
Expand All @@ -295,7 +295,7 @@
</xs:complexContent>
</xs:complexType>
<!-- ........................................................................ -->
<xs:element name="ML_DerivedCRS" type="gmx:ML_DerivedCRS_Type" substitutionGroup="gml:DerivedCRS"/>
<xs:element name="ML_DerivedCRS" type="gmx:ML_DerivedCRS_Type"/>
<!-- ........................................................................ -->
<xs:complexType name="ML_DerivedCRS_PropertyType">
<xs:sequence minOccurs="0">
Expand Down
2 changes: 1 addition & 1 deletion src/main/plugin/iso19139.ca.HNAP/schema/gmx/gmxUsage.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
</xs:complexType>
<!-- =========================================================================== -->
<!-- ........................................................................ -->
<xs:element name="MX_ScopeCode" type="gco:CodeListValue_Type" substitutionGroup="gmd:MD_ScopeCode"/>
<xs:element name="MX_ScopeCode" type="gco:CodeListValue_Type"/>
<!-- ........................................................................ -->
<xs:complexType name="MX_ScopeCode_PropertyType">
<xs:sequence minOccurs="0">
Expand Down
8 changes: 4 additions & 4 deletions src/main/plugin/iso19139.ca.HNAP/schema/gmx/uomItem.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
</xs:complexContent>
</xs:complexType>
<!-- ........................................................................ -->
<xs:element name="ML_BaseUnit" type="gmx:ML_BaseUnit_Type" substitutionGroup="gml:BaseUnit"/>
<xs:element name="ML_BaseUnit" type="gmx:ML_BaseUnit_Type"/>
<!-- ........................................................................ -->
<xs:complexType name="ML_BaseUnit_PropertyType">
<xs:sequence minOccurs="0">
Expand All @@ -81,7 +81,7 @@
</xs:complexContent>
</xs:complexType>
<!-- ........................................................................ -->
<xs:element name="ML_DerivedUnit" type="gmx:ML_DerivedUnit_Type" substitutionGroup="gml:DerivedUnit"/>
<xs:element name="ML_DerivedUnit" type="gmx:ML_DerivedUnit_Type"/>
<!-- ........................................................................ -->
<xs:complexType name="ML_DerivedUnit_PropertyType">
<xs:sequence minOccurs="0">
Expand All @@ -101,7 +101,7 @@
</xs:complexContent>
</xs:complexType>
<!-- ........................................................................ -->
<xs:element name="ML_ConventionalUnit" type="gmx:ML_ConventionalUnit_Type" substitutionGroup="gml:ConventionalUnit"/>
<xs:element name="ML_ConventionalUnit" type="gmx:ML_ConventionalUnit_Type"/>
<!-- ........................................................................ -->
<xs:complexType name="ML_ConventionalUnit_PropertyType">
<xs:sequence minOccurs="0">
Expand All @@ -121,7 +121,7 @@
</xs:complexContent>
</xs:complexType>
<!-- ........................................................................ -->
<xs:element name="ML_UnitDefinition" type="gmx:ML_UnitDefinition_Type" substitutionGroup="gml:UnitDefinition"/>
<xs:element name="ML_UnitDefinition" type="gmx:ML_UnitDefinition_Type"/>
<!-- ........................................................................ -->
<xs:complexType name="ML_UnitDefinition_PropertyType">
<xs:sequence minOccurs="0">
Expand Down