Merged
Conversation
proffapt
reviewed
Jul 29, 2025
Member
proffapt
left a comment
There was a problem hiding this comment.
bruhh
Please have commits, for a sane commit history. Makes the reviewer understand the flow of changes.
Member
Author
sorry, i kinda did everything together, will ensure from next time |
Member
|
build is failing |
harshkhandeparkar
approved these changes
Jul 31, 2025
Member
doesnt matter. im gonna squash and merge anyway :) |
Member
All in favor of removing his write privileges react 👍. |
Member
|
Baccho ko mat do |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since 2024 (admission batch), a new curriculum has been introduced wherein first year's curriculum is equivalent to other years. Each department has a predefined curriculum (the curriculum is no longer common), and no physics/chemistry semester type creation exists anymore. This makes the first years curriculum similar to other years. ERP also reports first year courses information in the same way it does for the courses of other years. This allows us to get rid of the separate handling of first year courses (via parsing a PDF), and just use the ERP scraper to get info about all the courses.
This PR
first_year_scraperand renamesother_years_scraperto justscrapercreate-react-app(deprecated) tovite.*iitkgp-erp-login-godependency (the version being used was buggy)*There was also a PWA and an associated service worker, I have not changed any code related to the service worker. Most probably it won't work since vite natively does not support service workers.
Fixes #85
Type of change
Checklist: