Migrate away from deprecated wrappers #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into optional-instead-of-stringvalue
…into optional-instead-of-stringvalue
Draft
… for quota thingy.
Gerrit91
approved these changes
Jul 24, 2025
Contributor
Gerrit91
left a comment
Gerrit91
left a comment
There was a problem hiding this comment.
In this release we should already start to migrate as many clients as possible. We can create an umbrella issue for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make API nicer but requires adoption of all consumers, or we take this approach:
also migrate this implementation to connect-go which is pure http/2 without authentication based on tls certificate, but instead with a token based approach and start this alongside the existing masterdata-api. Then new consumers connect to the new masterdata-api v1 with connect on port 80 and old consumers to the old api with the old port.