-
Notifications
You must be signed in to change notification settings - Fork 6
Support SHA512 hash for image verification #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This would raise a lot of work in other repos like, metal-images, metal-image-cache and potentially others. I would rather prefer that we try to move over to use OCI images. This format already includes signing and is a more commonly used format for such use-cases. |
|
Will merge after i validated #148 in our test environment ! |
|
Maybe this also helps in this respect: Should at least be noted in the Readme.md |
|
Any plan to merge or to close it? |
There are still no sha256 checksum generated, still interested in this but this must be done first. |
@mac641 are you interested to look into it? |
Yes, it reads interesting. I'll see what I can do. |
I am not sure if this is worth the effort, i would rather prefer to make metal-hammer able to pull metal-images as oci artifacts. This would also solve the signature check problem and must not be done for two algorithms as here |
Made a small sample here: #169 which should not be used as a real PR but as showcase how this could be achieved. if someone has spare time, raise your hands :-) |
Me ✋ |
Description
When a machine image is retrieved, its integrity is checked. Currently this is done with an md5 hash file next to the image file. This PR adds support for a sha512 checksum file. Thus, md5 and sha512 checksum files can be used for image verification. If both are present, sha512 will be used.