e2e: add logLevel tests for MetalLB core components #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaggapa
force-pushed
the
logleveltests
branch
2 times, most recently
from
9907ea4 to
fed73b1
Compare
oribon
reviewed
Jan 11, 2026
test/e2e/functional/tests/e2e.go
Outdated
Comment on lines
813
to
820
| err = testclient.Client.Get(context.Background(), goclient.ObjectKey{Namespace: metallb.Namespace, Name: metallb.Name}, metallb) | ||
| if !errors.IsNotFound(err) { | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| metallbutils.DeleteAndCheck(metallb) | ||
| // Get a fresh object after deletion to avoid ResourceVersion issues | ||
| metallb, err = metallbutils.Get(OperatorNameSpace, UseMetallbResourcesFromFile) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| } |
Member
There was a problem hiding this comment.
can we have this logic (starting from a clean state) in a BeforeEach?
test/e2e/functional/tests/e2e.go
Outdated
| } | ||
|
|
||
| Expect(testclient.Client.Create(context.Background(), metallb)).Should(Succeed()) | ||
| defer metallbutils.DeleteAndCheck(metallb) |
Member
There was a problem hiding this comment.
can we clean in AfterEach instead of this defer?
test/e2e/functional/tests/e2e.go
Outdated
Comment on lines
831
to
836
| By("Fetch controller pods from metallb-system namespace") | ||
| controllerPods, err := testclient.Client.Pods(OperatorNameSpace).List(context.Background(), metav1.ListOptions{ | ||
| LabelSelector: "component=controller", | ||
| }) | ||
| Expect(err).ToNot(HaveOccurred(), "Failed to list controller pods") | ||
| Expect(len(controllerPods.Items)).Should(BeNumerically(">", 0), "Controller Pods List should not be empty") |
Member
There was a problem hiding this comment.
can we have this (and the speaker one) in a func?
ajaggapa
force-pushed
the
logleveltests
branch
from
fed73b1 to
c3dc1e8
Compare
Contributor
Author
|
@oribon I have addressed your comments. Also i updated webhook error message for bgpBackend. Please check. |
Member
can you put it in a different commit please? 😅 |
oribon
reviewed
Jan 12, 2026
test/e2e/metallb/metallb.go
Outdated
|
|
||
| // GetMetalLBPods fetches pods for a given MetalLB component (controller or speaker) | ||
| // and validates that the list is not empty | ||
| func GetMetalLBPods(namespace string, component string) *v1.PodList { |
Member
There was a problem hiding this comment.
split this to two functions (speaker, controller)
ajaggapa
force-pushed
the
logleveltests
branch
4 times, most recently
from
9c76614 to
d6f3a4a
Compare
Contributor
Author
Updated |
ajaggapa
force-pushed
the
logleveltests
branch
2 times, most recently
from
82f942b to
6e93720
Compare
- Add tests to verify logLevel default and debug Signed-off-by: Anvesh J <[email protected]>
Signed-off-by: Anvesh J <[email protected]>
ajaggapa
force-pushed
the
logleveltests
branch
from
5c1e08d to
90eea2d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?: add new e2e test case
What this PR does / why we need it: Migrating two tests from https://github.com/rh-ecosystem-edge/eco-gotests/blob/074dcb73d119b91a6b01dff02e4998bfe50db0e7/tests/cnf/core/network/metallb/tests/bgp-tests.go#L144-L180
Special notes for your reviewer:
Release note: