Pause updates to the live graph while training is happening#825
Closed
glastonbridge wants to merge 4 commits intoappsfrom
Closed
Pause updates to the live graph while training is happening#825glastonbridge wants to merge 4 commits intoappsfrom
glastonbridge wants to merge 4 commits intoappsfrom
Conversation
These should now be complete except for Catalan which we'll update again before we ship.
|
Preview build will be at |
- Remove NavigatingToTesting enum value, keep stage as TrainingInProgress - Pause the SmoothieChart via a prop instead of unmounting LiveGraph - Remove "Training…" overlay text and its i18n string - Extend pause to cover the pre-train help dialog
microbit-matt-hillsdon
force-pushed
the
apps-pause-graph-on-training
branch
from
cac88c9 to
831a8b1
Compare
|
I've rebased this on the beta branch, tweaked to pause the graph rather than not render the graph and moved the pause one dialog earlier. I seem unable to change the base of this PR so will reopen. Closing. |
microbit-matt-hillsdon
added a commit
that referenced
this pull request
Mar 30, 2026
Essentially @glastonbridge's #825 but modified to pause the graph at the help dialog. Fixes #798 In order to stop visual flicker as the page changes out-of-step with the state machine for the training dialogs, I push the close dialog event onto the back of the event stack after a navigate, so it does not pre-emptively redraw the old page before hitting the navigate action. --------- Co-authored-by: Alex Shaw <alex.shaw@microbit.org>
|
Went into beta via #827 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #798
In order to stop visual flicker as the page changes out-of-step with the state machine for the training dialogs, I push the close dialog event onto the back of the event stack after a navigate, so it does not pre-emptively redraw the old page before hitting the navigate action. I also gave the final transitory dialog state a state machine state for clarity's sake though it doesn't do anything practically, it might be overblown.
Screen.Recording.2026-03-27.at.16.31.16.mov