Pause graph during training#827
Merged
microbit-matt-hillsdon merged 2 commits intobetafrom Mar 30, 2026
Merged
Conversation
- Remove NavigatingToTesting enum value, keep stage as TrainingInProgress - Pause the SmoothieChart via a prop instead of unmounting LiveGraph - Remove "Training…" overlay text and its i18n string - Extend pause to cover the pre-train help dialog
Author
|
I'll merge this into apps once it's in (we'll hit conflicts, but I just fixed them in reverse so should be fine). |
|
Preview build will be at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentially @glastonbridge's #825 but modified to pause the graph at the help dialog.
Fixes #798
In order to stop visual flicker as the page changes out-of-step with the state machine for the training dialogs, I push the close dialog event onto the back of the event stack after a navigate, so it does not pre-emptively redraw the old page before hitting the navigate action.