Skip to content

Fix 296: Changed Installation Link For Mac#304

Closed
krishi-agrawal wants to merge 1 commit intomicrocks:masterfrom
krishi-agrawal:fix-296
Closed

Fix 296: Changed Installation Link For Mac#304
krishi-agrawal wants to merge 1 commit intomicrocks:masterfrom
krishi-agrawal:fix-296

Conversation

@krishi-agrawal
Copy link
Contributor

@krishi-agrawal krishi-agrawal commented Feb 10, 2025

Description

Resolves #296

Signed-off-by: krishi-agrawal krishi.agrawal26@gmail.com

@krishi-agrawal
Copy link
Contributor Author

PTAL @yada

Copy link
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but too many changes are not related to issue #296
It looks like your branch was not updated before you pushed your PR?

@krishi-agrawal
Copy link
Contributor Author

It was updated but I got the DCO check error. So I tried to resolve that and hence more commits were added.

@yada
Copy link
Member

yada commented Feb 10, 2025

I know how tricky and frustrating Git can be (it happens to many of us all the time!)...
Let's try to dig further and see how we can manage and all learn at the same time ;) @Harsh4902 can you help here based on your previous experiences?

@krishi-agrawal
Copy link
Contributor Author

Sure! Thank you for understanding ;)

@Harsh4902
Copy link
Member

@krishi-agrawal I think you can squash all other commits in your first commit, then try to push it to your github branch forcefully. And maybe you have done something with previous commits of @lbroudoux and @vickybesra so you can avoid those changes also.

@krishi-agrawal
Copy link
Contributor Author

I squashed the commits and signed the PR but the check is still failing. What might be the problem @yada ?

@Harsh4902
Copy link
Member

I squashed the commits and signed the PR but the check is still failing. What might be the problem @yada ?

You didn't sign-off your commit. please try to run git rebase HEAD~1 --signoff and then again push it forcefully.

Signed-off-by: krishi-agrawal <krishi.agrawal26@gmail.com>
@krishi-agrawal
Copy link
Contributor Author

PTAL now @Harsh4902 @yada

@Harsh4902
Copy link
Member

Harsh4902 commented Feb 11, 2025

@krishi-agrawal DCO check is passing now, but I am not finding any changes in files. I think there can be some merge conflicts. Please try to resolve it.

Copy link
Member

@Harsh4902 Harsh4902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to see any change here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation link for Mac is inappropraite

4 participants