Support compressing metrics payload in OtlpConfig and OtlpHttpMetricsSender #7012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allnightlong
force-pushed
the
otlp-compression-mode
branch
from
a1116ea to
b95cf8c
Compare
shakuzen
changed the title
shakuzen
requested changes
Dec 22, 2025
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Looks good overall. Thanks for the quick and thorough pull request. I left some feedback.
...ions/micrometer-registry-otlp/src/main/java/io/micrometer/registry/otlp/CompressionMode.java
Outdated
Show resolved
Hide resolved
...entations/micrometer-registry-otlp/src/main/java/io/micrometer/registry/otlp/OtlpConfig.java
Outdated
Show resolved
Hide resolved
Member
|
Hi @allnightlong, I wanted to follow-up to see if you have time and interest to update this pull request based on the review I left. Let us know. We'd like to get this feature into the upcoming minor release. |
Contributor
Author
|
@shakuzen thanks for follow up |
allnightlong
force-pushed
the
otlp-compression-mode
branch
from
d33d473 to
0a03711
Compare
allnightlong
changed the title
allnightlong
force-pushed
the
otlp-compression-mode
branch
3 times, most recently
from
6d9a501 to
4ac8ad2
Compare
Add compressionMode parameter to OtlpMetricsSender.Request to support configurable compression in metrics requests. Signed-off-by: Tigran Kavanosyan <[email protected]>
Wire compression mode configuration through to the HTTP metrics sender to enable configurable compression. Signed-off-by: Tigran Kavanosyan <[email protected]>
Add test coverage for compression mode resolution from configuration and environment variables. Signed-off-by: Tigran Kavanosyan <[email protected]>
Refactor compression mode configuration logic into a dedicated compressionModeFromConfig() method for better code organization. Signed-off-by: Tigran Kavanosyan <[email protected]>
Signed-off-by: Tigran Kavanosyan <[email protected]>
Signed-off-by: Tigran Kavanosyan <[email protected]>
Change enum values from ON/OFF to GZIP/NONE to align with OpenTelemetry specification naming conventions. Signed-off-by: Tigran Kavanosyan <[email protected]>
Add fallback to the generic OTEL_EXPORTER_OTLP_COMPRESSION environment variable when the metrics-specific variable is not set. Signed-off-by: Tigran Kavanosyan <[email protected]>
Signed-off-by: Tigran Kavanosyan <[email protected]>
Fix compression mode tests to use valid enum values (GZIP, NONE) instead of invalid values (ON, OFF). Add test coverage for OTEL_EXPORTER_OTLP_COMPRESSION fallback environment variable and precedence between generic and metrics-specific compression env vars. Signed-off-by: Tigran Kavanosyan <[email protected]>
allnightlong
force-pushed
the
otlp-compression-mode
branch
2 times, most recently
from
ad3776d to
9d4ec09
Compare
allnightlong
changed the title
shakuzen
reviewed
Jan 20, 2026
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Thanks a lot for the updates. It is looking great. Could we also add an integration test to ensure this actually works with an OTLP endpoint? I think a test case could probably be added to OTelCollectorIntegrationTest with gzip compression enabled in the config. Other than that, updating the documentation would also be good, but if you're not up for that we can take care of it separately.
Adds a test case to OTelCollectorIntegrationTest that verifies metrics export successfully when CompressionMode.GZIP is enabled. Signed-off-by: Tigran Kavanosyan <[email protected]>
allnightlong
force-pushed
the
otlp-compression-mode
branch
from
54fecbd to
aa4ee50
Compare
Contributor
Author
|
@shakuzen I've added the integration test - please check it out |
shakuzen
approved these changes
Jan 20, 2026
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the quick updates. I'll work on merging it tomorrow with some documentation updates.
jonatan-ivanov
added a commit
that referenced
this pull request
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7009