Fix missing artifact warning #3900
Conversation
trask
requested review from
harsimar,
heyams,
jeanbisutti and
ramthi
as code owners
agent/instrumentation/applicationinsights-web-2.3/build.gradle.kts
Outdated
Show resolved
Hide resolved
| compileOnly("com.microsoft.azure:applicationinsights-web:2.3.0") | ||
|
|
||
| testImplementation("io.opentelemetry.instrumentation:opentelemetry-instrumentation-annotations:$otelVersion") | ||
| testImplementation("io.opentelemetry.instrumentation:opentelemetry-instrumentation-annotations:$otelInstrumentationVersion") |
There was a problem hiding this comment.
can you put a note saying when it's moved from sdk to otelInstrumentation?
There was a problem hiding this comment.
can you put a note saying when it's moved from sdk to otelInstrumentation?
I didn't follow this comment, can you clarify? thanks
There was a problem hiding this comment.
this has been there for 2 years. I just want to know when it was moved to a different artifact and put a comment there.
There was a problem hiding this comment.
ah, it has always been wrong
it just happened to work because before we bumped instrumentation repo to 2.x it generally had the same version number as the SDK repo
There was a problem hiding this comment.
plus, it's still "working" (CI passes), it just logs a warning which I think S360 may be complaining about
| } | ||
|
|
||
| val otelInstrumentationAlphaVersion: String by project | ||
| val otelVersion: String by project |
There was a problem hiding this comment.
can you rename otelVersion from dependencyManagement to otelSdkVersion?
otelVersion seems confusing.
There was a problem hiding this comment.
sure, can I send a follow-up PR for that since it's unrelated to this PR?
I think this warning that mentions
repo.maven.apache.orgmay be what's triggering (one of) the current S360 violations: