Skip to content

Fix missing artifact warning #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix missing artifact warning #3900

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f2e1e6
Fix missing artifact warning
trask Oct 9, 2024
4df2834
not alpha
trask Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions agent/instrumentation/applicationinsights-web-2.3/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ muzzle {
}

val otelInstrumentationAlphaVersion: String by project
val otelVersion: String by project
Copy link
Contributor

@heyams heyams Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rename otelVersion from dependencyManagement to otelSdkVersion?

otelVersion seems confusing.

Copy link
Member Author

@trask trask Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, can I send a follow-up PR for that since it's unrelated to this PR?

Copy link
Contributor

@heyams heyams Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np

val otelInstrumentationVersion: String by project

dependencies {
compileOnly("com.microsoft.azure:applicationinsights-web:2.3.0")

testImplementation("io.opentelemetry.instrumentation:opentelemetry-instrumentation-annotations:$otelVersion")
testImplementation("io.opentelemetry.instrumentation:opentelemetry-instrumentation-annotations:$otelInstrumentationVersion")
Copy link
Contributor

@heyams heyams Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put a note saying when it's moved from sdk to otelInstrumentation?

Copy link
Member Author

@trask trask Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put a note saying when it's moved from sdk to otelInstrumentation?

I didn't follow this comment, can you clarify? thanks

Copy link
Contributor

@heyams heyams Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been there for 2 years. I just want to know when it was moved to a different artifact and put a comment there.

Copy link
Member Author

@trask trask Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it has always been wrong

it just happened to work because before we bumped instrumentation repo to 2.x it generally had the same version number as the SDK repo

Copy link
Member Author

@trask trask Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plus, it's still "working" (CI passes), it just logs a warning which I think S360 may be complaining about


testImplementation("com.microsoft.azure:applicationinsights-web:2.3.0")
testImplementation("javax.servlet:javax.servlet-api:3.0.1")
Expand Down
Loading