Skip to content

Don't log Log Records if they are sampled out #3936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Don't log Log Records if they are sampled out #3936

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eda9e28
Move comment
trask Oct 25, 2024
831a346
Merge remote-tracking branch 'origin/main' into move-comment
trask Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...main/java/com/microsoft/applicationinsights/agent/internal/exporter/AgentLogExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ private CompletableResultCode internalExport(Collection<LogRecordData> logs) {
return CompletableResultCode.ofFailure();
}
for (LogRecordData log : logs) {
logger.debug("exporting log: {}", log);
try {
int severityNumber = log.getSeverity().getSeverityNumber();
if (severityNumber < severityThreshold) {
Expand Down Expand Up @@ -124,6 +123,8 @@ private CompletableResultCode internalExport(Collection<LogRecordData> logs) {
continue;
}

logger.debug("exporting log: {}", log);

TelemetryItem telemetryItem = mapper.map(log, stack, samplingPercentage);
telemetryItemConsumer.accept(telemetryItem);

Expand Down
Loading