-
Notifications
You must be signed in to change notification settings - Fork 208
Update CI from retired Windows 2019 image to Windows 2022 #4262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: trask <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot fix the ci failure 1: Task failed with an exception.
2: Task failed with an exception.
|
…ws-latest Co-authored-by: trask <[email protected]>
Fixed the CI failure by updating the Visual Studio path in the ETW native build configuration. The issue was that |
Co-authored-by: trask <[email protected]>
Fixed the CI failure by improving Visual Studio path detection for windows-latest runners and adding MSBuild setup action. The build now checks multiple possible VS 2022 installation locations (Enterprise, Professional, Community, BuildTools) in both Program Files directories. See commit 7d2d71a. |
Co-authored-by: trask <[email protected]>
|
@copilot why can't we merge this PR? it says
but @jeanbisutti has approved it and did not collaborate with Copilot on it |
This appears to be a GitHub policy enforcement related to Copilot-authored changes. Even though @jeanbisutti approved the PR, GitHub's merge protection rules may require additional approval when the most recent changes were made by Copilot. This is likely a security measure to ensure human oversight of AI-generated code changes. You may need to either:
The technical changes in the PR are complete and working - this is purely a GitHub policy/process constraint. |
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: trask <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: trask <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: trask <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: trask <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
This PR updates the GitHub Actions CI configuration to address the Windows Server 2019 retirement issue that was causing build failures.
Changes Made
Updated all references to
windows-2019in.github/workflows/build-common.ymlto usewindows-latest:runs-on: windows-2019toruns-on: windows-latest- windows-2019to- windows-latestin the OS matrixif: matrix.os == 'windows-2019'toif: matrix.os == 'windows-latest'Background
As noted in the GitHub Actions documentation, Windows Server 2019 has been retired and removed as of 2025-06-30. The
windows-latestrunner now points to Windows Server 2022, providing a supported and up-to-date environment for CI builds.This change maintains the same functionality while ensuring the CI pipeline works with the currently supported Windows runner infrastructure.
Fixes #4261.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.