Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/build-common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:

assemble:
# running (and uploading artifact) from windows since only that build includes etw
runs-on: windows-2019
runs-on: windows-2022
steps:
- name: Support long paths
run: git config --system core.longpaths true
Expand All @@ -103,6 +103,17 @@ jobs:
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4

- name: Add MSBuild to PATH
uses: microsoft/setup-msbuild@v2

- name: Setup Visual Studio and Windows SDK environment
shell: cmd
run: |
"%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath > vs.txt
set /p VSPATH=<vs.txt
echo APPINSIGHTS_VS_PATH=%VSPATH%>>%GITHUB_ENV%
echo APPINSIGHTS_WIN10_SDK_PATH=C:\Program Files (x86)\Windows Kits\10>>%GITHUB_ENV%

- name: Assemble
# javadoc task fails sporadically fetching https://docs.oracle.com/javase/8/docs/api/
run: >
Expand Down Expand Up @@ -131,13 +142,13 @@ jobs:
# TODO (trask) enable once profiler supports OpenJ9
# - openj9
os:
- windows-2019
- windows-2022
- ubuntu-latest
fail-fast: false
steps:
- name: Support long paths
run: git config --system core.longpaths true
if: matrix.os == 'windows-2019'
if: matrix.os == 'windows-2022'

- uses: actions/checkout@v4

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
permissions:
actions: read
security-events: write
runs-on: windows-latest
runs-on: windows-2022

steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# CHANGELOG

## Version 3.7.3 GA (05/28/2025)

### Enhancements
Expand Down
2 changes: 1 addition & 1 deletion etw/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The build should find the tools and Windows SDK, but if needed these environment
* Default: `"%ProgramFiles(x86)%/Windows Kits/10"`
* `APPINSIGHTS_VS_PATH`
* Location of Visual Studio Build Tools
* Default: `%ProgramFiles(x86)%/Microsoft Visual Studio 14.0`
* Default: `%ProgramFiles(x86)%/Microsoft Visual Studio/2022/Enterprise`
* `APPINSIGHTS_WIN_SDK_LIB_PATH`
* Location of Windows 10 SDK library folder (for linker requirements)
* Default: `%APPINSIGHTS_WIN10_SDK_PATH%/Lib/10.0.18362.0/um`
Expand Down
8 changes: 5 additions & 3 deletions etw/native/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@ if (System.env.APPINSIGHTS_WIN10_SDK_PATH) {
winSdkDir = System.env.APPINSIGHTS_WIN10_SDK_PATH
logger.info "Windows SDK path set with environment variable, APPINSIGHTS_WIN10_SDK_PATH"
}
def vsToolsDir = "$programFilesX86/Microsoft Visual Studio 14.0"
// Visual Studio Build Tools path - use environment variable if available, fallback to standard path
def vsToolsDir = System.env.APPINSIGHTS_VS_PATH ?: "$programFilesX86/Microsoft Visual Studio/2022/BuildTools"
if (System.env.APPINSIGHTS_VS_PATH) {
vsToolsDir = System.env.APPINSIGHTS_VS_PATH
logger.info "Visual Studio Build Tools path set with environment variable, APPINSIGHTS_VS_PATH"
logger.info "Visual Studio Build Tools path set with environment variable: $vsToolsDir"
} else {
logger.info "Using default Visual Studio Build Tools path: $vsToolsDir"
}

logger.info "Windows SDK: $winSdkDir"
Expand Down