Update JmxMetric smoke test to use new assertion framework #4337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the JmxMetric smoke test to use the new assertion framework introduced in #4141, making the test more readable and maintainable while keeping changes minimal.
Changes Made
1. Updated
verifyJmxMetricsSentToBreezemethodwaitForItemscalls with fluenttesting.waitAndAssertMetric()callsNameWithDot- validates value equals 5DefaultJmxMetricNameOverride- validates metric existsBooleanJmxMetric- validates value equals 1.0DotInAttributeNameAsPathSeparator- validates metric existsLoaded Class Count- validates metric exists2. Extended
MetricAssertclasshasNoInternalAttributes()method to validate that metrics don't contain properties starting withapplicationinsights.internal.verifyNoInternalAttributes()helper method3. Maintained existing logic
Testing
spotlessApplyThe changes maintain backward compatibility while modernizing the assertions to use the new fluent API pattern.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.