fix compiler issue re: Reverse() method in Test project.#2958
Merged
TimothyMothra merged 3 commits intomainfrom Feb 18, 2025
Merged
fix compiler issue re: Reverse() method in Test project.#2958TimothyMothra merged 3 commits intomainfrom
Reverse() method in Test project.#2958TimothyMothra merged 3 commits intomainfrom
Conversation
added 2 commits
February 18, 2025 09:55
Reverse() methodReverse() method in Test project.
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (3)
WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryProcessorTests.cs:646
- The second
ToArray()call is redundant and should be removed.
var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Reverse().ToArray();
WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryProcessorTests.cs:825
- The second
ToArray()call is redundant and should be removed.
Assert.AreEqual(TelemetryDocumentType.RemoteDependency.ToString(), accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Reverse().ToArray().Single().DocumentType);
WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryProcessorTests.cs:3201
- The
Reverse()method was removed. Confirm if this change was intentional and doesn't affect the test logic.
var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray().ToArray();
WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryProcessorTests.cs
Outdated
Show resolved
Hide resolved
WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryProcessorTests.cs
Outdated
Show resolved
Hide resolved
rajkumar-rangaraj
approved these changes
Feb 18, 2025
Member
rajkumar-rangaraj
left a comment
There was a problem hiding this comment.
Please check copilot comments before the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered a new issue affecting test projects today.
The problems appears to be with the use of the
Reverse()method.In each of the use cases, the
Reverse()method is being called on an array ofTelemetryDocumentobjects.Each of the use cases are expecting to use the Linq Reverse method, which returns an IEnumerable and can be used to chain multiple methods.
Instead, the compiler has started selecting the Array Reverse method which returns a void which causes the above error.
I don't know what has caused the sudden breaking change. The last successful build was 2 weeks ago and was using .NET 8.0.12. Today's CI is using 8.0.13.
This PR fixes the issue by changing the order in which Reverse() is called to ensure it's being called on an Enumerable instead of on the Array type.