Skip to content

fix compiler issue re: Reverse() method in Test project. #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimothyMothra merged 3 commits into from
Feb 18, 2025
Merged

fix compiler issue re: Reverse() method in Test project. #2958

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d0ba3c
investigating
Feb 18, 2025
a4452b0
reintroduce Reverse
Feb 18, 2025
6bc4296
pr feedback
Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryProcessorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ public void QuickPulseTelemetryProcessorCollectsFullTelemetryItemsAndDistributes
telemetryProcessor.Process(trace);

// ASSERT
var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray().Reverse().ToArray();
var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Reverse().ToArray();

var expectedProperties =
new Dictionary<string, string>()
Expand Down Expand Up @@ -766,7 +766,7 @@ public void QuickPulseTelemetryProcessorHandlesRequestSuccessSpecialCaseCorrectl

// ASSERT
// even though Success is set to false, since ResponseCode is empty the special case logic must have turned it into true
var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray().Reverse().ToArray().Single();
var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Single();
double metricValue = accumulatorManager.CurrentDataAccumulator.CollectionConfigurationAccumulator.MetricAccumulators["Metric1"].CalculateAggregation(out long count);

Assert.AreEqual(1, count);
Expand Down Expand Up @@ -822,7 +822,7 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullTelemetryItemsIfTypeIs
telemetryProcessor.Process(dependency);

// ASSERT
Assert.AreEqual(TelemetryDocumentType.RemoteDependency.ToString(), accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray().Reverse().ToArray().Single().DocumentType);
Assert.AreEqual(TelemetryDocumentType.RemoteDependency.ToString(), accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Single().DocumentType);
}

[TestMethod]
Expand Down Expand Up @@ -911,16 +911,16 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullRequestTelemetryItemsO
var collectedTelemetryStreamAll =
accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(document => document.DocumentStreamIds.Contains("StreamAll"))
.ToArray()
.Reverse()
.Cast<RequestTelemetryDocument>()
.Reverse()
.ToArray();

var collectedTelemetryStreamSuccessOnly =
accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(
document => document.DocumentStreamIds.Contains("StreamSuccessOnly"))
.ToArray()
.Reverse()
.Cast<RequestTelemetryDocument>()
.Reverse()
.ToArray();

// the quota is 3 initially, then 0.5 every second (but not more than 30)
Expand Down Expand Up @@ -1038,16 +1038,16 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullDependencyTelemetryIte
var collectedTelemetryStreamAll =
accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(document => document.DocumentStreamIds.Contains("StreamAll"))
.ToArray()
.Reverse()
.Cast<DependencyTelemetryDocument>()
.Reverse()
.ToArray();

var collectedTelemetryStreamSuccessOnly =
accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(
document => document.DocumentStreamIds.Contains("StreamSuccessOnly"))
.ToArray()
.Reverse()
.Cast<DependencyTelemetryDocument>()
.Reverse()
.ToArray();

// the quota is 3 initially, then 0.5 every second (but not more than 30)
Expand Down Expand Up @@ -1166,16 +1166,16 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullExceptionTelemetryItem
var collectedTelemetryStreamAll =
accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(document => document.DocumentStreamIds.Contains("StreamAll"))
.ToArray()
.Reverse()
.Cast<ExceptionTelemetryDocument>()
.Reverse()
.ToArray();

var collectedTelemetryStreamSuccessOnly =
accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(
document => document.DocumentStreamIds.Contains("StreamSuccessOnly"))
.ToArray()
.Reverse()
.Cast<ExceptionTelemetryDocument>()
.Reverse()
.ToArray();

// the quota is 3 initially, then 0.5 every second (but not more than 30)
Expand Down Expand Up @@ -1292,13 +1292,13 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullEventTelemetryItemsOnc
var collectedTelemetryStreamAll =
accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(document => document.DocumentStreamIds.Contains("StreamAll"))
.ToArray()
.Reverse()
.Cast<EventTelemetryDocument>()
.Reverse()
.ToArray();

var collectedTelemetryStreamSuccessOnly =
accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(
document => document.DocumentStreamIds.Contains("StreamSuccessOnly")).ToArray().Reverse().Cast<EventTelemetryDocument>().ToArray();
document => document.DocumentStreamIds.Contains("StreamSuccessOnly")).ToArray().Cast<EventTelemetryDocument>().Reverse().ToArray();

// the quota is 3 initially, then 0.5 every second (but not more than 30)

Expand Down Expand Up @@ -1413,16 +1413,16 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullTraceTelemetryItemsOnc
var collectedTelemetryStreamAll =
accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(document => document.DocumentStreamIds.Contains("StreamAll"))
.ToArray()
.Reverse()
.Cast<TraceTelemetryDocument>()
.Reverse()
.ToArray();

var collectedTelemetryStreamSuccessOnly =
accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(
document => document.DocumentStreamIds.Contains("StreamSuccessOnly"))
.ToArray()
.Reverse()
.Cast<TraceTelemetryDocument>()
.Reverse()
.ToArray();

// the quota is 3 initially, then 0.5 every second (but not more than 30)
Expand Down Expand Up @@ -1520,8 +1520,8 @@ public void QuickPulseTelemetryProcessorDoesNotCollectFullTelemetryItemsOnceGlob
var collectedTelemetryForStream =
accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Where(document => document.DocumentStreamIds.Contains(streamId))
.ToArray()
.Reverse()
.Cast<RequestTelemetryDocument>()
.Reverse()
.ToArray();

Assert.AreEqual(maxGlobalTelemetryQuota, collectedTelemetryForStream.Length);
Expand Down Expand Up @@ -3154,7 +3154,7 @@ public void VerifyBehaviorWhenDeferredIsTrue()
// ASSERT
Assert.IsFalse(accumulatorManager.CurrentDataAccumulator.GlobalDocumentQuotaReached);
Assert.AreEqual(1, accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Count);
var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray().Reverse().ToArray();
var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray();

Assert.AreEqual(TelemetryDocumentType.Request, Enum.Parse(typeof(TelemetryDocumentType), collectedTelemetry[0].DocumentType));
var requestTelemetryDocument = (RequestTelemetryDocument)collectedTelemetry[0];
Expand Down Expand Up @@ -3198,7 +3198,7 @@ public void VerifyBehaviorWhenDeferredIsFalse()
// ASSERT
Assert.IsFalse(accumulatorManager.CurrentDataAccumulator.GlobalDocumentQuotaReached);
Assert.AreEqual(1, accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.Count);
var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray().Reverse().ToArray();
var collectedTelemetry = accumulatorManager.CurrentDataAccumulator.TelemetryDocuments.ToArray();

Assert.AreEqual(TelemetryDocumentType.Request, Enum.Parse(typeof(TelemetryDocumentType), collectedTelemetry[0].DocumentType));
var requestTelemetryDocument = (RequestTelemetryDocument)collectedTelemetry[0];
Expand Down
Loading