Issue 5818. Changed OnLookup triger to OnDrilldown trigger, changed name of handling method for assist edit. #5837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andleOnLookupSourceTable to be HandleOnAssistEditSourceTable
github-actions
bot
added
AL: Apps (W1)
PredragMaricic
previously approved these changes
Dec 16, 2025
tomasevicst
previously approved these changes
Dec 16, 2025
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary Not needed anymore. We kept it for old repo due to links. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes # [AB#614186](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/614186)
…es (microsoft#5967) Navigate to Results list from Result Code Add missing Drill Down for Inspection Lines Fixes: - [AB#615771](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615771) - [AB#617015](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/617015)
…ties. Extra changes. (microsoft#5991) This PR contains minor changes required to adding new demo data for PA: - Fixing preparation of the temporary buffer before doing historical matching, specifically for allocation account. The reason is that the name of the allocation account is different from what we have in the purchase invoice lines after splitting the allocation account to G/L accounts. - Fixing sample purchase invoice functionality by populating the description on the lines - Adding new countries to demodata app.json [AB#579972](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/579972/)
…icrosoft#5932) Improving inbound e-document page: - Show task id for the inbound e-document and open the task pane when user click the field - Show both confirmed and extracted vendors - Change first fields on the inbound e-documents page based on the UX review Side: Add missing sorting for using statements to pass the build Fixes [AB#607925](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/607925)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#614168](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/614168)
Reverting unnecessary change to the inbound e-documents page that make the Import PDF action visible Fixes [AB#579972](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/579972)
…y Order Lines (microsoft#5964) ### Summary Enhanced the Shopify Order Subform page to automatically set the Unit of Measure Code when an Item is selected on an order line. ### Changes **File:** ShpfyOrderSubform.Page.al - Added `OnValidate` trigger to the "Item No." field that automatically populates the "Unit of Measure Code" based on the selected item: - If the item has a "Sales Unit of Measure" defined, it uses that value - Otherwise, it falls back to the item's "Base Unit of Measure" ### Motivation When users manually map Shopify order lines to Business Central items, they previously had to manually enter the Unit of Measure Code. This change improves the user experience by automatically defaulting the UoM based on the item's configuration, reducing manual data entry and potential errors. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#617019](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/617019)
…5963) ## Add Data Capture support for Fulfillment Orders ### Summary This PR adds Data Capture functionality for Fulfillment Orders, mirroring the existing implementation for Order Fulfillments. This allows users to view the raw JSON data retrieved from Shopify for debugging and troubleshooting purposes. ### Changes #### Pages - **ShpfyFulfillmentOrderCard.Page.al**: Added "Retrieved Shopify Data" action with `actionref` in the promoted area to view captured data for the selected fulfillment order - **ShpfyFulFillmentOrders.Page.al**: Added the same "Retrieved Shopify Data" action to the list page for quick access from the list view #### Table - **ShpfyFulFillmentOrderHeader.Table.al**: Extended `OnDelete` trigger to clean up associated Data Capture records when a fulfillment order header is deleted #### Codeunit - **ShpfyFulfillmentOrdersAPI.Codeunit.al**: - Added `DataCapture.Add()` call in `ExtractFulfillmentOrder` to save the fulfillment order JSON response - Added `DataCapture.Add()` call in `ExtractFulfillmentOrderLines` to save the fulfillment order lines JSON response #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#616999](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616999)
### Summary This PR adds extensibility for Shopify product metafields, allowing external developers to programmatically manage metafields through a public facade codeunit and integration events. ### Problem External developers cannot programmatically: - Retrieve metafield definitions for products/variants - Add metafields with values when missing - Force-sync metafields to Shopify outside of the standard item sync ### Solution Implemented a public facade pattern (similar to existing `Shpfy Product` and `Shpfy Orders` codeunits) for metafield management. ### Changes - **ShpfyMetafields.Codeunit.al** - Public facade codeunit with: - `GetMetafieldDefinitions(ParentTableNo, OwnerId, ShopCode)` - Retrieve metafield definitions from Shopify - `SyncMetafieldToShopify(Metafield, ShopCode): BigInteger` - Sync a single metafield to Shopify - `SyncMetafieldsToShopify(ParentTableNo, OwnerId, ShopCode)` - Sync all metafields for a resource - **ShpfyProductEvents.Codeunit.al** - Added `OnBeforeUpdateProductMetafields(ProductId: BigInteger)` integration event - **ShpfyProductExport.Codeunit.al** - Raises `OnBeforeUpdateProductMetafields` event before syncing metafields - Refactored to use public facade for metafield operations - **ShpfyMetafields.Page.al** - Added "Sync to Shopify" action with multi-select support - Refactored to use public facade for all metafield operations - **ShpfyCustomerExport.Codeunit.al** - Refactored to use public facade for metafield sync - **ShpfyCompanyExport.Codeunit.al** - Refactored to use public facade for metafield sync #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#617035](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/617035)
…rkflows in the external-dependencies group across 1 directory (microsoft#5891) Bumps the external-dependencies group with 1 update in the /.github/workflows directory: [step-security/harden-runner](https://github.com/step-security/harden-runner). Updates `step-security/harden-runner` from 2.13.3 to 2.14.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/step-security/harden-runner/releases">step-security/harden-runner's releases</a>.</em></p> <blockquote> <h2>v2.14.0</h2> <h2>What's Changed</h2> <ul> <li>Selective installation: Harden-Runner now skips installation on GitHub-hosted runners when the repository has a custom property skip_harden_runner, allowing organizations to opt out specific repos.</li> <li>Avoid double install: The action no longer installs Harden-Runner if it’s already present on a GitHub-hosted runner, which could happen when a composite action also installs it.</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/step-security/harden-runner/compare/v2.13.3...v2.14.0">https://github.com/step-security/harden-runner/compare/v2.13.3...v2.14.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/step-security/harden-runner/commit/20cf305ff2072d973412fa9b1e3a4f227bda3c76"><code>20cf305</code></a> Merge pull request <a href="https://redirect.github.com/step-security/harden-runner/issues/622">#622</a> from step-security/feature/custom-property-skip</li> <li><a href="https://github.com/step-security/harden-runner/commit/c51e8eeb6c4fdcd08f65e43a051dacdbfaa69702"><code>c51e8ee</code></a> feat: skip agent install and post step on subsequent runs for GitHub-hosted r...</li> <li><a href="https://github.com/step-security/harden-runner/commit/e152b90204c3d85cefa1441b701a47a13ed28bd7"><code>e152b90</code></a> feat: skip harden-runner based on repository custom property</li> <li><a href="https://github.com/step-security/harden-runner/commit/ee1faec052d1000061fa79a13e030db11b3f86bd"><code>ee1faec</code></a> feat: replace skip-harden-runner with skip-on-custom-property input</li> <li><a href="https://github.com/step-security/harden-runner/commit/1dc7c1764659d537dab2a854b8e165a801103eb1"><code>1dc7c17</code></a> feat: add skip-harden-runner input to conditionally skip execution</li> <li>See full diff in <a href="https://github.com/step-security/harden-runner/compare/df199fb7be9f65074067a9eb93f12bb4c5547cf2...20cf305ff2072d973412fa9b1e3a4f227bda3c76">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…microsoft#6012) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#615833](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615833)
…ry for ".." entry (microsoft#5894) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Issue: When using the folder selection dialog, if a user navigates into a directory and then selects the ".." (back/parent) entry and clicks OK, the function returns an invalid path containing the literal ".." segment (e.g., Docs/mine/2025/../). Fix: Added a check to detect when the ".." navigation entry is selected and return the current directory path directly instead of combining it with the ".." literal. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes microsoft#5893 Fixes [AB#616797](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616797) --------- Co-authored-by: Tine Staric <[email protected]>
…andleOnLookupSourceTable to be HandleOnAssistEditSourceTable
Conflicts:
src/Apps/W1/Quality Management/app/src/Configuration/GenerationRule/QltyInspectionGenRule.Table.al
src/Apps/W1/Quality Management/app/src/Configuration/GenerationRule/QltyInspectionGenRules.Page.al
Resolved merge conflicts.
auto-merge was automatically disabled
January 5, 2026 19:34
Head branch was pushed to by a user without write access
github-actions
bot
added
Build: Automation
PredragMaricic
previously approved these changes
Jan 6, 2026
insightworks007
dismissed
PredragMaricic’s stale review
The merge-base changed after approval.
PredragMaricic
previously approved these changes
Jan 6, 2026
insightworks007
dismissed
PredragMaricic’s stale review
The merge-base changed after approval.
Contributor
Author
|
PR #6044 replaces this PR to handle recent object renames. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #6044 replaces this PR to handle recent object renames.
Changed Schedule Group OnLookup to OnDrillDown, Changed HandleOnLookupSourceTable to be HandleOnAssistEditSourceTable
Summary
Changed procedure HandleOnLookupSourceTable to Changed procedure HandleOnAssistEditSourceTable.
Changed Schedule Group field from a lookup to a drill-down, and consequently moved code from the table to the page.
Work Item(s)
#5818
#5818
(AB#611289) . Lookup->AssistEdit, and Lookup->Drilldown changes.