-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add support for streaming through entities #5517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…pport Merge pull request #1 from kylerohnmsft/main
…this is pretty rough)
This needs design feedback from @compulim before it goes further. |
@compulim PR validation checks are failing intermittently, can you rerun? |
![]() I think it legitimately fail. Unit tests rarely flaky. |
I was talking about a previous one. This was me, I forgot to update unit tests |
Changelog Entry
entities
in PR #5517 by @kylerohnnote: actual changes made by kylerohnmsft, but linking personal account to show contribution after internship ends
Description
Microsoft platforms such as the Agents SDKs are now putting streaming information in the
entities
field rather than thechannelData
field. This means that BotFramework-WebChat must be able to handle reading streaming data from either location, prioritizing reading from entities.Design
Nothing fundamental about the code flow was changed. getActivityLivestreamingMetadata() was edited such that entities is checked for streaming data before channelData. If the streaming data is found in entities, it uses that data to encode the livestreaming metadata. Otherwise, it moves on to channelData and the code executes as it did before. Changes were made to abstract some of the Schema structure such that overall code maintenance should be easier moving forward.
Specific Changes
entities
field of activity for streaming dataentities
-
CHANGELOG.md
Review Checklist
z-index
)package.json
andpackage-lock.json
reviewed