-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add support for streaming through entities #5517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kylerohnmsft
wants to merge
39
commits into
microsoft:main
Choose a base branch
from
MattB-msft:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+306
−49
Open
Changes from 26 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
7d7adb8
delete `text` from typing activities which are not streaming
5860d06
add support for reading streaming data in `entities`
b09797d
Merge branch 'feature/entities-streaming-support' into main
kylerohnmsft 64bdfa8
Merge pull request #1 from kylerohnmsft/main
kylerohnmsft 48b0ea1
Merge pull request #2 from kylerohnmsft/feature/entities-streaming-su…
kylerohnmsft e680dd4
refactoring to pass existing html2 test cases
684a78b
minimal implementation of entities livestreaming
1d569a1
Rewrite code flow to check for streamingData first -- draft version (…
d5cd926
Change conditionals to be more readable and actually check channelData
87442e2
handle case of entities being undefined
c72ad0f
Make channelData optional in entitiesStreamingActivitySchema
e34df98
make channelData not optional for entitiesStreamingActivitySchema
211a8a7
change looseObject back to object
f6596cf
handle entities being undefined again
3b0da48
clean up logical flow and include more typing
fcc5512
Removed common data from schemas for reusability
f881517
read channelData instead of entities
5f5fe92
remove unnecessary field from StreamingData
8f01f68
typing+final+text activity returns undefined
07797eb
further abstraction of schemas
53980b5
update unit tests
07e0418
edit changelog
3d1bfa3
Merge branch 'microsoft:main' into main
kylerohn 0778a90
finish changelog
kylerohn ed212de
edit docs
kylerohn 1e89aeb
allow for optional channelData in entities streaming schema
abea4be
Merge branch 'temp'
0c29c8f
added jsdoc to StreamingData interface
d335e2e
fix naming issues
b8a886d
add sample
5515771
trigger CI
3f905ad
fix sample
ef54b41
require type: streaminfo field for streaming data in entities
5abefa2
fix unit tests to reflect added `entities` field
145373f
Merge branch 'main' into main
kylerohnmsft 674c80e
Merge branch 'main' into main
MattB-msft d4315e2
Merge branch 'main' into main
MattB-msft 061ca3a
Merge branch 'main' into main
MattB-msft 2795c34
Merge branch 'main' into main
MattB-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.