fix: Optimize the network module for Researcher #714
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Azure infrastructure Bicep modules to improve clarity, modularity, and maintainability of private networking resources. The main changes include replacing the monolithic
network.bicepmodule with a more focusedvirtualNetwork.bicepmodule, updating parameter names for consistency, and ensuring all resource references use the new module outputs. Additionally, Azure Bastion Host and Jumpbox VM provisioning logic is now handled directly inmain.bicep, and all dependent resources have been updated to reference the new output names and structures.Network module refactoring and resource provisioning:
network.bicepmodule and its outputs, replacing it with a newvirtualNetwork.bicepmodule that provides more granular outputs for each subnet and resource, improving modularity and clarity. (infra/modules/network.bicep)virtualNetworkmodule, and added direct provisioning for Azure Bastion Host and Jumpbox VM resources inmain.bicep, with improved parameter naming and resource referencing.Parameter and variable renaming for consistency:
vmAdminUsername/vmAdminPasswordtovirtualMachineAdminUsername/virtualMachineAdminPasswordfor improved clarity and consistency across modules.Resource reference updates across dependent modules:
virtualNetworkinstead of the oldnetworkmodule outputs, ensuring correct subnet and resource IDs are used for private networking. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]These changes will make the infrastructure codebase easier to maintain and extend, and ensure that all resources are correctly provisioned and referenced when private networking is enabled.## Purpose
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information