-
Notifications
You must be signed in to change notification settings - Fork 554
refactor(tree): Misc. column/row insert/remove improvements #25206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Josmithr
wants to merge
72
commits into
microsoft:main
from
Josmithr:tree/table-insert-methods-refactoring
Closed
refactor(tree): Misc. column/row insert/remove improvements #25206
Josmithr
wants to merge
72
commits into
microsoft:main
from
Josmithr:tree/table-insert-methods-refactoring
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting on #25213 |
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
All of the test changes here have been merged in separately, as well as some of the structural changes in the table schema code. The final perf improvement is now being done in a separate PR here: #25329 Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: tree
area: dds
Issues related to distributed data structures
base: main
PRs targeted against main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a significant perf difference between inserting single columns/rows and inserting lists of them. To help encourage group inserts,
insertColumn
andinsertRow
have been removed. Users can leverage the group alternatives instead (insertColumns
andinsertRows
).Additionally, there is a significant performance difference between removing single / disjoint columns/rows and removing contiguous ranges of them. To address this, overloads have been added to
removeColumns
andremoveRows
to allow removing by index range. When possible, this is the most performant option.removeColumns
andremoveRows
have also been updated to calculate the set of contiguous ranges represented lists of nodes or IDs to minimize the number of removal ops made in each transaction.Benchmark test updates
Updates both SharedTree table and SharedMatrix perf tests to include batch column/row insertion tests.
Batch removal tests will come in a future PR, due to some of the current limitations around column + cell removal.