-
Notifications
You must be signed in to change notification settings - Fork 554
refactor(tree): Misc. column/row insert/remove improvements #25206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Josmithr
wants to merge
72
commits into
microsoft:main
from
Josmithr:tree/table-insert-methods-refactoring
Closed
Changes from 39 commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
a920d4f
refactor: Extract interface
Josmithr 968c35a
docs: Update comments
Josmithr cbe3972
refactor: Small cleanup
Josmithr de9f281
refactor: Unify helpers
Josmithr 9a7634f
style: Line break
Josmithr 37691d7
refactor: Rename variables
Josmithr 6a8b9db
test: Improve validation patterns
Josmithr e17f456
refactor: Remove duplicate assertion
Josmithr 767fbaa
refactor: Use interface instead of class
Josmithr 8f263ea
test: Add event listeners
Josmithr be4c707
refactor: Use interface instead of class
Josmithr 3a99c23
refactor: Use common helper base
Josmithr 81976cf
refactor: Remove unnecessary parameters
Josmithr 7764ec1
refactor: Shared interface definitions
Josmithr 7741eef
docs: TODOs
Josmithr 2cfd250
Merge branch 'main' into table-perf-test-updates
Josmithr 7a83a17
refactor: Unify argument names
Josmithr c9eeebd
refactor: Dedupe option properties
Josmithr 8a946c4
refactor: Small initialization optimization
Josmithr 37b5795
refactor: Add options type and allow sparse table
Josmithr 3539e9e
docs: Add missing comment
Josmithr c82ed94
fix: Tests
Josmithr 79490c4
refactor: Use single helper
Josmithr 8d042c4
test: Clean up pre-post operation validation
Josmithr 3911f4d
refactor: Remove unneeded return values
Josmithr 81f0cc9
fix: Leverage shared helper
Josmithr 2acc79c
test: Update pattern
Josmithr e0ec7b2
refactor: Unify variable naming
Josmithr 80a099b
docs: Add comments
Josmithr ab6796d
Merge branch 'main' into table-perf-test-updates
Josmithr 82a1169
fix: Dispose undo/redo manager
Josmithr 542b029
WIP
Josmithr 1183dc7
Merge branch 'table-perf-test-updates' into tree/table-insert-methods…
Josmithr c536733
fix: Tests
Josmithr 6a1eb11
refactor: Remove single insert/remove methods and add range removal m…
Josmithr 31695b2
fix: Index querying
Josmithr bbc3c61
fix: API and input validation
Josmithr f3a27bd
test: Add by-ID coverage
Josmithr 44431ab
Merge branch 'main' into tree/table-insert-methods-refactoring
Josmithr 1edd336
docs: Update comments
Josmithr 57bc97d
docs: Update comments
Josmithr cbe042e
test: Add perf tests for batch row and column insertion
Josmithr e31e385
docs: Update docs
Josmithr 52cc631
docs: Update API report
Josmithr 78eb83a
docs: Fix comment typo
Josmithr d960faa
fix: Call correct APIs
Josmithr 814acd3
fix: Handling of ranges in transactions
Josmithr f349dd2
refactor: Use `count` instead of `end`
Josmithr c6dac4d
docs: Update API report
Josmithr 37108bf
Merge branch 'tree/table-insert-methods-refactoring' of https://githu…
Josmithr 3edc347
improvement(tree): Update `removeColumn` to remove cells as well
Josmithr 480af16
docs: Update changeset
Josmithr 6c6fd1a
improvement: Use removal API
Josmithr f5cfdbe
improvement: Use index overloads
Josmithr f0c1a83
fix: Make index parameter optional
Josmithr 2983ee9
docs: Update API reports
Josmithr 73193a3
docs: Add notes about perf concerns
Josmithr b1173c4
Merge branch 'main' into tree/table-column-deletion
Josmithr ffffef2
Merge branch 'main' into tree/table-insert-methods-refactoring
Josmithr 94346c3
Merge branch 'tree/table-column-deletion' into tree/table-insert-meth…
Josmithr 716e643
Merge branch 'main' into tree/table-insert-methods-refactoring
Josmithr daec8e2
refactor: Better index find pattern
Josmithr 6ca61e2
Merge branch 'main' into tree/table-insert-methods-refactoring
Josmithr 8fae8e4
Merge branch 'main' into tree/table-insert-methods-refactoring
Josmithr eaa244a
Merge branch 'main' into tree/table-insert-methods-refactoring
Josmithr e008aa5
Merge branch 'main' into tree/table-insert-methods-refactoring
Josmithr ada4bd5
Merge branch 'main' into tree/table-insert-methods-refactoring
Josmithr 6b5cf52
Merge branch 'main' into tree/table-insert-methods-refactoring
Josmithr 5d283b3
Merge branch 'main' into tree/table-insert-methods-refactoring
Josmithr 9ea66fb
test: Remove `.only`
Josmithr e5fe282
docs: Remove stale TODO
Josmithr b335d8c
test: Remove duplicated tests
Josmithr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: add changeset