Use updated tenant steps in stress pipeline #25437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the stress test pipeline to use the new tenant pool infrastructure for ODSP production tests, removing the previous locking mechanism and integrating with the tenant management system introduced in PR #23382.
- Removes the
stress-odsp-lockvariable group from the ODSP stress test stage - Updates the template logic to include
stress_tests_odspin tenant pool operations - Excludes
stress_tests_odspfrom sequential lock behavior while keeping other stages locked
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/pipelines/test-real-service-stress.yml | Removes the stageVariables section that referenced the stress-odsp-lock group |
| tools/pipelines/templates/include-test-real-service.yml | Updates conditional logic to include stress_tests_odsp in tenant pool operations and exclude it from sequential locking |
Abe27342
reviewed
Sep 12, 2025
| ${{ if and(ne(parameters.stageId, 'e2e_odsp'), ne(parameters.stageId, 'stress_tests_odsp')) }}: | ||
| ${{ parameters.env }} | ||
| ${{ if eq(parameters.stageId, 'e2e_odsp') }}: | ||
| ${{ if or(eq(parameters.stageId, 'e2e_odsp'), eq(parameters.stageId, 'stress_tests_odsp')) }}: |
Contributor
There was a problem hiding this comment.
looks like we really probably just want an if/else here. You should be able to use ${{ else }}
Contributor
|
i see the test run took ~20 minutes longer. There are some other instances of odsp taking about as long, but could you double-check that we're still using distinct user accounts for the different runners in stress with this approach and keep an eye on if that 1h30m run is an anomaly or a trend after merging? |
Abe27342
approved these changes
Sep 12, 2025
scarlettjlee
approved these changes
Sep 12, 2025
jzaffiro
added a commit
that referenced
this pull request
Sep 25, 2025
Follow up to #25437, which mistakenly left the old tenants in the stress pipeline. Remove this and use the new tenants fully.
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
Use the new tenants introduced in microsoft#23382 in the stress test pipeline for the ODSP prod stage. Largely follows the same steps as the E2E change and uses the infrastructure from that PR. This only deals with ODSP prod - the ODSPDF stage will be updated in a follow-up. [AB#48372](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/48372)
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
Follow up to microsoft#25437, which mistakenly left the old tenants in the stress pipeline. Remove this and use the new tenants fully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new tenants introduced in #23382 in the stress test pipeline for the ODSP prod stage. Largely follows the same steps as the E2E change and uses the infrastructure from that PR. This only deals with ODSP prod - the ODSPDF stage will be updated in a follow-up.
AB#48372