-
Notifications
You must be signed in to change notification settings - Fork 562
(compat) Removed deprecated properties from IContainerStorageService and IRuntimeStorageService #25708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(compat) Removed deprecated properties from IContainerStorageService and IRuntimeStorageService #25708
Conversation
…and IRuntimeStorageService
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes deprecated properties from IRuntimeStorageService and IContainerStorageService interfaces, constituting a breaking change previously announced in release 2.52.0. The removal includes 9 properties from IRuntimeStorageService and 3 from IContainerStorageService.
Key Changes:
- Removed deprecated methods and properties from storage service interfaces
- Updated type validation configurations to mark breaking changes
- Removed obsolete test code that relied on deprecated functionality
- Updated import statements to remove unused types
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/runtime/runtime-definitions/src/protocol.ts | Removed 9 deprecated properties from IRuntimeStorageService interface |
| packages/common/container-definitions/src/runtime.ts | Removed 3 deprecated properties from IContainerStorageService interface |
| packages/runtime/container-runtime/src/storageServiceWithAttachBlobs.ts | Removed deprecated method implementations from proxy class |
| packages/loader/container-loader/src/containerStorageAdapter.ts | Removed downloadSummary method and cleaned up imports |
| packages/test/test-end-to-end-tests/src/test/deRehydrateContainerTests.spec.ts | Removed test case validating deprecated getSnapshotTree behavior |
| packages/runtime/container-runtime/src/test/containerRuntime.spec.ts | Changed mock type from IRuntimeStorageService to IContainerStorageService |
| packages/loader/container-loader/src/container.ts | Updated import and parameter type references |
| .changeset/heavy-bugs-thank.md | Added changeset documenting the breaking changes |
| Multiple package.json files | Added type validation entries marking interfaces as breaking backward compatibility |
| Multiple validation files | Added ts-expect-error comments for compatibility type checks |
tylerbutler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changeset looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping to see code related to deprecations has lint suppressions. Makes it clear that the code removed was deprecation related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this non-breaking change to a separate PR and merged it.
1ce13ac to
a81d271
Compare
| - `disposed` | ||
| - `downloadSummary` | ||
|
|
||
| Please see [this Github issue](https://github.com/microsoft/FluidFramework/issues/25069) for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'Github'?
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
|
@microsoft-github-policy-service rerun |
…and IRuntimeStorageService (microsoft#25708) ## Description Removed deprecated properties from "IRuntimeStorageService" and "IContainerStorageService" The following deprecated properties have been removed from `IRuntimeStorageService`: - `createBlob` - `dispose` - `disposed` - `downloadSummary` - `getSnapshot` - `getSnapshotTree` - `getVersions` - `policies` - `uploadSummaryWithContext` The following deprecated properties have been removed from `IContainerStorageService`: - `dispose` - `disposed` - `downloadSummary` ## Breaking Changes This is a breaking change. The deprecations were announced in release 2.52.0 [here](https://github.com/microsoft/FluidFramework/releases/tag/client_v2.52.0).
Description
Removed deprecated properties from "IRuntimeStorageService" and "IContainerStorageService"
The following deprecated properties have been removed from
IRuntimeStorageService:createBlobdisposedisposeddownloadSummarygetSnapshotgetSnapshotTreegetVersionspoliciesuploadSummaryWithContextThe following deprecated properties have been removed from
IContainerStorageService:disposedisposeddownloadSummaryBreaking Changes
This is a breaking change. The deprecations were announced in release 2.52.0 here.