Skip to content

Conversation

@agarwal-navin
Copy link
Contributor

Description

Removed deprecated properties from "IRuntimeStorageService" and "IContainerStorageService"

The following deprecated properties have been removed from IRuntimeStorageService:

  • createBlob
  • dispose
  • disposed
  • downloadSummary
  • getSnapshot
  • getSnapshotTree
  • getVersions
  • policies
  • uploadSummaryWithContext

The following deprecated properties have been removed from IContainerStorageService:

  • dispose
  • disposed
  • downloadSummary

Breaking Changes

This is a breaking change. The deprecations were announced in release 2.52.0 here.

Copilot AI review requested due to automatic review settings October 16, 2025 17:21
@agarwal-navin agarwal-navin requested review from a team as code owners October 16, 2025 17:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated properties from IRuntimeStorageService and IContainerStorageService interfaces, constituting a breaking change previously announced in release 2.52.0. The removal includes 9 properties from IRuntimeStorageService and 3 from IContainerStorageService.

Key Changes:

  • Removed deprecated methods and properties from storage service interfaces
  • Updated type validation configurations to mark breaking changes
  • Removed obsolete test code that relied on deprecated functionality
  • Updated import statements to remove unused types

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/runtime/runtime-definitions/src/protocol.ts Removed 9 deprecated properties from IRuntimeStorageService interface
packages/common/container-definitions/src/runtime.ts Removed 3 deprecated properties from IContainerStorageService interface
packages/runtime/container-runtime/src/storageServiceWithAttachBlobs.ts Removed deprecated method implementations from proxy class
packages/loader/container-loader/src/containerStorageAdapter.ts Removed downloadSummary method and cleaned up imports
packages/test/test-end-to-end-tests/src/test/deRehydrateContainerTests.spec.ts Removed test case validating deprecated getSnapshotTree behavior
packages/runtime/container-runtime/src/test/containerRuntime.spec.ts Changed mock type from IRuntimeStorageService to IContainerStorageService
packages/loader/container-loader/src/container.ts Updated import and parameter type references
.changeset/heavy-bugs-thank.md Added changeset documenting the breaking changes
Multiple package.json files Added type validation entries marking interfaces as breaking backward compatibility
Multiple validation files Added ts-expect-error comments for compatibility type checks

@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc changeset-present public api change Changes to a public API base: main PRs targeted against main branch labels Oct 16, 2025
Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset looks good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to see code related to deprecations has lint suppressions. Makes it clear that the code removed was deprecation related.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this non-breaking change to a separate PR and merged it.

@agarwal-navin agarwal-navin force-pushed the test/breaks/client/2.70/cleanupStorageService branch from 1ce13ac to a81d271 Compare October 20, 2025 23:43
- `disposed`
- `downloadSummary`

Please see [this Github issue](https://github.com/microsoft/FluidFramework/issues/25069) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'Github'?

@github-actions
Copy link
Contributor

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

 ELIFECYCLE  Command failed with exit code 1.

@agarwal-navin
Copy link
Contributor Author

@microsoft-github-policy-service rerun

@agarwal-navin agarwal-navin merged commit 82c936e into main Oct 23, 2025
43 checks passed
@agarwal-navin agarwal-navin deleted the test/breaks/client/2.70/cleanupStorageService branch October 23, 2025 21:00
anthony-murphy-agent pushed a commit to anthony-murphy-agent/FluidFramework that referenced this pull request Jan 14, 2026
…and IRuntimeStorageService (microsoft#25708)

## Description

Removed deprecated properties from "IRuntimeStorageService" and
"IContainerStorageService"

The following deprecated properties have been removed from
`IRuntimeStorageService`:

- `createBlob`
- `dispose`
- `disposed`
- `downloadSummary`
- `getSnapshot`
- `getSnapshotTree`
- `getVersions`
- `policies`
- `uploadSummaryWithContext`

The following deprecated properties have been removed from
`IContainerStorageService`:

- `dispose`
- `disposed`
- `downloadSummary`

## Breaking Changes

This is a breaking change. The deprecations were announced in release
2.52.0
[here](https://github.com/microsoft/FluidFramework/releases/tag/client_v2.52.0).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch changeset-present public api change Changes to a public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated properties from "IRuntimeStorageService" and "IContainerStorageService"

5 participants