build(client): bump eslint-config-fluid to v8#25774
Merged
tylerbutler merged 56 commits intomicrosoft:mainfrom Nov 5, 2025
Merged
build(client): bump eslint-config-fluid to v8#25774tylerbutler merged 56 commits intomicrosoft:mainfrom
tylerbutler merged 56 commits intomicrosoft:mainfrom
Conversation
github-actions
bot
added
area: dds
github-actions
bot
removed
area: build
github-actions
bot
added
the
dependencies
tylerbutler
force-pushed
the
eslint-import-upgrade-client-v8
branch
from
e39f7ec to
1420ef4
Compare
# Conflicts: # packages/common/container-definitions/package.json # packages/common/core-interfaces/package.json # packages/common/core-utils/package.json # packages/common/driver-definitions/package.json # packages/dds/counter/package.json # packages/dds/map/package.json # packages/dds/matrix/package.json # packages/dds/merge-tree/package.json # packages/dds/ordered-collection/package.json # packages/dds/register-collection/package.json # packages/dds/sequence/package.json # packages/dds/shared-object-base/package.json # packages/dds/shared-summary-block/package.json # packages/dds/task-manager/package.json # packages/drivers/debugger/package.json # packages/drivers/driver-base/package.json # packages/drivers/driver-web-cache/package.json # packages/drivers/file-driver/package.json # packages/drivers/local-driver/package.json # packages/drivers/odsp-driver-definitions/package.json # packages/drivers/odsp-driver/package.json # packages/drivers/odsp-urlResolver/package.json # packages/drivers/replay-driver/package.json # packages/drivers/routerlicious-driver/package.json # packages/drivers/routerlicious-urlResolver/package.json # packages/drivers/tinylicious-driver/package.json # packages/framework/fluid-static/package.json # packages/framework/request-handler/package.json # packages/loader/container-loader/package.json # packages/loader/driver-utils/package.json # packages/runtime/container-runtime-definitions/package.json # packages/runtime/container-runtime/package.json # packages/runtime/datastore-definitions/package.json # packages/runtime/datastore/package.json # packages/runtime/id-compressor/package.json # packages/runtime/runtime-definitions/package.json # packages/runtime/runtime-utils/package.json # packages/runtime/test-runtime-utils/package.json # packages/test/test-utils/package.json # packages/tools/devtools/devtools-core/package.json # packages/tools/devtools/devtools/package.json # packages/tools/fluid-runner/package.json # packages/utils/odsp-doclib-utils/package.json # packages/utils/telemetry-utils/package.json # packages/utils/tool-utils/package.json # pnpm-lock.yaml
Contributor
|
I think we are going with #25806 instead of this one, right? Or should I review this too? |
Member
Author
My plan was to get this one merged first, then merge the other one. Trying to keep lint changes separate from the workspace layout changes. THat said, I'll probably merge whichever one that gets approved/passing CI first. :) |
alexvy86
reviewed
Nov 4, 2025
Contributor
alexvy86
left a comment
alexvy86
left a comment
There was a problem hiding this comment.
Most comments are the same issue across several packages.
alexvy86
reviewed
Nov 4, 2025
Contributor
alexvy86
left a comment
alexvy86
left a comment
There was a problem hiding this comment.
Most comments are the same issue across several packages.
Contributor
|
I think merging this before #25806 makes sense, it'll update all the source files with the new rule name/scope, making the other one easier to review. With the changes to publishing, disabled scripts, policy checks, etc, I think it's worth it to have that one be smaller and easier to review thoroughly. |
Abe27342
approved these changes
Nov 5, 2025
Contributor
Abe27342
left a comment
Abe27342
left a comment
There was a problem hiding this comment.
merge-tree/matrix changes look good. Did not review the rest of the PR :)
jason-ha
reviewed
Nov 6, 2025
| @@ -13,7 +15,6 @@ import { | |||
| } from "./testValues.js"; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/consistent-type-imports -- incorrect rule: misunderstands `declare`d types. | |||
Contributor
There was a problem hiding this comment.
Is there a rogue disable sitting around now?
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates ESLint configuration and usage throughout the client release group to use the new
import-xESLint plugin instead of the previousimportplugin. It also upgrades the@fluidframework/eslint-config-fluidpackage to version 8.1.0 across all relevantpackage.jsonfiles.Unfortunately the switch to import-x from the import plugin isn't something we can easily do in parts. See #25807, which doesn't work unfortunately.
With that in mind, this PR both updates the ESLint config version AND updates all import/ disables and config to be import-x/ instead.
Note
If it is helpful, I can refactor this into two commits, one for the package.json changes and one for the other files. Let me know if it's useful (I'm lazy and don't want to do it if no one cares).