test(client-presence): minor typing #26125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves type safety and code clarity in test utilities by making the logger parameter required and suppressing a lint warning where appropriate.
- Makes
loggerparameter required inprepareConnectedPresenceandassertFinalExpectationsfunctions - Adds eslint suppression with explanation for intentional use of
JSON.parse(JSON.stringify())pattern - Updates JSDoc comments to reflect the required logger parameter
logger is always passed; just make it required. suppress `unicorn/prefer-structured-clone` warning.
jason-ha
force-pushed
the
test/presence/minor-cleanup
branch
from
96a7417 to
c56cb3e
Compare
WillieHabi
approved these changes
Jan 16, 2026
jason-ha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logger is always passed; just make it required.