Skip to content

test(client-presence): minor typing #26125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jason-ha merged 1 commit into from
Jan 16, 2026
Merged

test(client-presence): minor typing #26125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/framework/presence/src/test/testUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,12 +262,12 @@ const localAvgLatency = 10;
function createPresence(
runtime: MockEphemeralRuntime,
attendeeId: string,
logger?: EventAndErrorTrackingLogger,
logger: EventAndErrorTrackingLogger,
): {
presence: ReturnType<typeof createPresenceManager>;
processSignal: ProcessSignalFunction;
} {
logger?.registerExpectedEvent({ eventName: "Presence:PresenceInstantiated" });
logger.registerExpectedEvent({ eventName: "Presence:PresenceInstantiated" });

const presence = createPresenceManager(runtime, attendeeId as AttendeeId);
const processSignal = createProcessSignal(presence);
Expand All @@ -289,14 +289,14 @@ function createPresence(
* @param attendeeId - the client session id given to presence
* @param clientConnectionId - the client connection id
* @param clock - the fake timer.
* @param logger - optional logger to track telemetry events
* @param logger - logger to track telemetry events
*/
export function prepareConnectedPresence(
runtime: MockEphemeralRuntime,
attendeeId: string,
clientConnectionId: ClientConnectionId,
clock: Omit<SinonFakeTimers, "restore">,
logger?: EventAndErrorTrackingLogger,
logger: EventAndErrorTrackingLogger,
): {
presence: PresenceWithNotifications;
processSignal: ProcessSignalFunction;
Expand Down Expand Up @@ -343,14 +343,14 @@ export function prepareConnectedPresence(
* @param attendeeId - the client session id given to presence
* @param clientConnectionId - the client connection id to use when connecting
* @param clock - the fake timer
* @param logger - optional logger to track telemetry events
* @param logger - logger to track telemetry events
*/
export function prepareDisconnectedPresence(
runtime: MockEphemeralRuntime,
attendeeId: string,
clientConnectionId: ClientConnectionId,
clock: Omit<SinonFakeTimers, "restore">,
logger?: EventAndErrorTrackingLogger,
logger: EventAndErrorTrackingLogger,
): {
presence: PresenceWithNotifications;
processSignal: ProcessSignalFunction;
Expand Down Expand Up @@ -411,7 +411,7 @@ export function prepareDisconnectedPresence(
*/
export function assertFinalExpectations(
runtime: MockEphemeralRuntime,
logger?: EventAndErrorTrackingLogger,
logger: EventAndErrorTrackingLogger,
): void {
// Make sure all expected events were logged and there are no unexpected errors.
const logErrors = getUnexpectedLogErrorException(logger);
Expand Down
Loading