-
Notifications
You must be signed in to change notification settings - Fork 562
improvement(eslint-config-fluid): Disable eslint rule that yields false positives #26137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement(eslint-config-fluid): Disable eslint rule that yields false positives #26137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR disables the unicorn/no-array-callback-reference ESLint rule globally to eliminate false positives that occur when non-array types implement methods with the same names as array methods (e.g., map, forEach, reduce, find).
- Disables
unicorn/no-array-callback-referencein the base ESLint configuration - Removes all local overrides and inline disable comments for this rule throughout the codebase
- Updates CHANGELOG to document the rule change
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| common/build/eslint-config-fluid/recommended.js | Adds global disable for unicorn/no-array-callback-reference with explanatory comment |
| common/build/eslint-config-fluid/CHANGELOG.md | Documents the rule change in the Unreleased section |
| common/build/eslint-config-fluid/printed-configs/*.json | Updates all printed config files to reflect the rule being "off" |
| packages/dds/tree/.eslintrc.cjs | Removes package-specific override that's no longer needed |
| packages/dds/tree/eslint.config.mts | Removes package-specific override that's no longer needed |
| packages/framework/tree-agent/src/test/schemaUtils.spec.ts | Removes file-level disable comments for the rule |
| packages/framework/tree-agent/src/test/prompt.spec.ts | Removes inline disable comment for sf.map() call |
| packages/drivers/odsp-driver/src/odspDocumentDeltaConnection.ts | Removes inline disable comment for SocketReference.find() call |
| packages/dds/map/src/map.ts | Removes inline disable comment for forEach() call |
| packages/dds/map/src/directory.ts | Removes inline disable comment for forEach() call |
| examples/benchmarks/bubblebench/ot/src/proxy/tree.ts | Removes inline disable comment for reduce() call |
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
…se positives (microsoft#26137) Disables `unicorn/no-array-callback-reference`, which yields false positives for non-array methods with the same name as array methods.
Disables
unicorn/no-array-callback-reference, which yields false positives for non-array methods with the same name as array methods.