Skip to content

Conversation

@Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Jan 6, 2026

Disables unicorn/no-array-callback-reference, which yields false positives for non-array methods with the same name as array methods.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables the unicorn/no-array-callback-reference ESLint rule globally to eliminate false positives that occur when non-array types implement methods with the same names as array methods (e.g., map, forEach, reduce, find).

  • Disables unicorn/no-array-callback-reference in the base ESLint configuration
  • Removes all local overrides and inline disable comments for this rule throughout the codebase
  • Updates CHANGELOG to document the rule change

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
common/build/eslint-config-fluid/recommended.js Adds global disable for unicorn/no-array-callback-reference with explanatory comment
common/build/eslint-config-fluid/CHANGELOG.md Documents the rule change in the Unreleased section
common/build/eslint-config-fluid/printed-configs/*.json Updates all printed config files to reflect the rule being "off"
packages/dds/tree/.eslintrc.cjs Removes package-specific override that's no longer needed
packages/dds/tree/eslint.config.mts Removes package-specific override that's no longer needed
packages/framework/tree-agent/src/test/schemaUtils.spec.ts Removes file-level disable comments for the rule
packages/framework/tree-agent/src/test/prompt.spec.ts Removes inline disable comment for sf.map() call
packages/drivers/odsp-driver/src/odspDocumentDeltaConnection.ts Removes inline disable comment for SocketReference.find() call
packages/dds/map/src/map.ts Removes inline disable comment for forEach() call
packages/dds/map/src/directory.ts Removes inline disable comment for forEach() call
examples/benchmarks/bubblebench/ot/src/proxy/tree.ts Removes inline disable comment for reduce() call

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  245432 links
    1786 destination URLs
    2025 URLs ignored
       0 warnings
       0 errors


@Josmithr Josmithr requested a review from a team January 6, 2026 23:29
@Josmithr Josmithr merged commit 4939842 into microsoft:main Jan 7, 2026
43 checks passed
@Josmithr Josmithr deleted the eslint-config-fluid/disable-map-rule branch January 7, 2026 18:12
anthony-murphy-agent pushed a commit to anthony-murphy-agent/FluidFramework that referenced this pull request Jan 14, 2026
…se positives (microsoft#26137)

Disables `unicorn/no-array-callback-reference`, which yields false
positives for non-array methods with the same name as array methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants