build(eslint-config-fluid): restore as independent workspace by tylerbutler · Pull Request #26427 · microsoft/FluidFramework

tylerbutler · 2026-02-12T02:27:48Z

Summary

Reverses #25806 which temporarily moved @fluidframework/eslint-config-fluid into the client release group. The package is restored as an independently versioned workspace at v9.0.0, preparing it for its next published release with ESLint 9 flat config support.

Key changes

eslint-config-fluid: Version set to 9.0.0, removed private: true, removed typeValidation block in package.json. All ESLint 9 work (flat config, typescript-eslint 8.54, etc.) is preserved.
pnpm-workspace.yaml: Package removed from workspace members. Added an eslint catalog group for eslint, eslint-config-prettier, and @fluid-internal/eslint-config-fluid.
Root package.json: Uses link: protocol with a pnpm override to resolve references across the workspace, plus a postinstall script to install transitive deps. ESLint version moved to catalog:eslint.
Client packages: Dependencies changed from workspace:~ to catalog:eslint for eslint-config-fluid, eslint, and eslint-config-prettier.
fluidBuild.config.cjs: Removed temporary npm-private-packages policy exclusion; added npm-package-types-field exclusion.
syncpack.config.cjs: Added ignore rules for eslint-config-fluid (link: protocol is unresolvable by syncpack).
build-eslint-config-fluid.yml: Re-enabled taskPack for publishing.

Copilot

Pull request overview

Restores @fluidframework/eslint-config-fluid as an independently versioned workspace (v9.0.0) instead of being part of the client release group, and updates the repo to consume it via ~9.0.0 while using a local link: override for in-repo development/builds.

Changes:

Removed common/build/eslint-config-fluid from the root pnpm workspace and re-enabled its publish/pack behavior in CI.
Updated repo packages to depend on @fluidframework/eslint-config-fluid via ~9.0.0 instead of workspace:*.
Updated root dependency resolution to use link: + pnpm override and added a root postinstall to install transitive deps for the linked config.

Reviewed changes

Copilot reviewed 161 out of 162 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/pipelines/build-eslint-config-fluid.yml	Re-enables default packing behavior by removing the `taskPack: false` override.
tools/pipelines/build-client.yml	Removes temporary path exclusions now that eslint-config-fluid is no longer in the client release group.
syncpack.config.cjs	Re-enables syncpack version consistency checks for `@fluidframework/eslint-config-fluid`.
pnpm-workspace.yaml	Removes `common/build/eslint-config-fluid` from the root workspace packages list.
package.json	Adds a postinstall to install eslint-config-fluid’s deps; switches root dependency to local link and adds pnpm override.
fluidBuild.config.cjs	Removes temporary policy-check exclusion for eslint-config-fluid.
common/build/eslint-config-fluid/package.json	Marks eslint-config-fluid as publishable again and bumps version to 9.0.0.
packages/utils/tool-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/utils/telemetry-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/utils/odsp-doclib-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/tools/replay-tool/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/tools/fluid-runner/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/tools/fetch-tool/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/tools/devtools/devtools/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/tools/devtools/devtools-view/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/tools/devtools/devtools-test-app/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/tools/devtools/devtools-core/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/tools/devtools/devtools-browser-extension/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/tools/changelog-generator-wrapper/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/test-version-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/test-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/test-service-load/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/test-pairwise-generator/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/test-end-to-end-tests/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/test-drivers/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/test-driver-definitions/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/stochastic-test-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/snapshots/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/mocha-test-setup/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/local-server-tests/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/local-server-stress-tests/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/test/functional-tests/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/service-clients/tinylicious-client/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/service-clients/odsp-client/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/service-clients/end-to-end-tests/odsp-client/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/service-clients/end-to-end-tests/azure-client/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/service-clients/azure-client/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/runtime/test-runtime-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/runtime/runtime-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/runtime/runtime-definitions/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/runtime/id-compressor/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/runtime/datastore/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/runtime/datastore-definitions/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/runtime/container-runtime/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/runtime/container-runtime-definitions/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/loader/test-loader-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/loader/driver-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/loader/container-loader/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/undo-redo/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/tree-agent/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/tree-agent-ses/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/tree-agent-langchain/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/synthesize/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/request-handler/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/react/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/presence/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/oldest-client-observer/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/fluid-static/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/fluid-framework/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/dds-interceptions/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/data-object-base/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/attributor/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/aqueduct/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/framework/agent-scheduler/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/drivers/tinylicious-driver/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/drivers/routerlicious-urlResolver/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/drivers/routerlicious-driver/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/drivers/replay-driver/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/drivers/odsp-urlResolver/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/drivers/odsp-driver/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/drivers/odsp-driver-definitions/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/drivers/local-driver/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/drivers/file-driver/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/drivers/driver-web-cache/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/drivers/driver-base/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/drivers/debugger/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/tree/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/test-dds-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/task-manager/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/shared-summary-block/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/shared-object-base/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/sequence/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/register-collection/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/pact-map/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/ordered-collection/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/merge-tree/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/matrix/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/map/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/legacy-dds/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/ink/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/counter/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/dds/cell/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/common/driver-definitions/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/common/core-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/common/core-interfaces/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/common/container-definitions/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
packages/common/client-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
experimental/framework/last-edited/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
experimental/framework/data-objects/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
experimental/dds/tree/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
experimental/dds/sequence-deprecated/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
experimental/dds/ot/sharejs/json1/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
experimental/dds/ot/ot/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/view-integration/view-framework-sampler/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/view-integration/external-views/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/view-integration/container-views/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/version-migration/tree-shim/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/version-migration/separate-container/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/version-migration/same-container/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/version-migration/live-schema-upgrade/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/utils/webpack-fluid-loader/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/utils/migration-tools/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/utils/import-testing/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/utils/example-webpack-integration/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/utils/example-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/utils/example-driver/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/utils/bundle-size-tests/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/service-clients/odsp-client/shared-tree-demo/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/service-clients/azure-client/todo-list/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/service-clients/azure-client/external-controller/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/external-data/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/webflow/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/todo/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/text-editor/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/table-tree/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/table-document/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/smde/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/prosemirror/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/multiview/triangle-view/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/multiview/slider-coordinate-view/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/multiview/plot-coordinate-view/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/multiview/interface/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/multiview/coordinate-model/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/multiview/container/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/multiview/constellation-view/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/multiview/constellation-model/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/monaco/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/inventory-app/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/codemirror/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/clicker/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/data-objects/canvas/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/client-logger/app-insights-logger/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/benchmarks/tablebench/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/benchmarks/odspsnapshotfetch-perftestapp/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/benchmarks/bubblebench/shared-tree/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/benchmarks/bubblebench/ot/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/benchmarks/bubblebench/experimental-tree/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/benchmarks/bubblebench/common/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/benchmarks/bubblebench/baseline/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/apps/tree-comparison/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/apps/tree-cli-app/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/apps/task-selection/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/apps/staging/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/apps/presence-tracker/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/apps/diceroller/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/apps/data-object-grid/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/apps/contact-collection/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/apps/collaborative-textarea/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
examples/apps/blobs/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
azure/packages/azure-service-utils/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.
azure/packages/azure-local-service/package.json	Switches eslint-config-fluid dependency to `~9.0.0`.

syncpack.config.cjs

package.json

examples/apps/blobs/package.json

common/build/eslint-config-fluid/package.json

fluidBuild.config.cjs

package.json

pnpm-lock.yaml

Add comment for npm-package-types-field exclusion and use pnpm -C with --frozen-lockfile for postinstall.

Resolve merge conflict in package.json keeping both install:agency and postinstall scripts.

Updated build-tools to 0.64.0, kept eslint catalog and version 9.0.0 with private flag from main.

The package needs to be published, so it should not be marked private.

package.json

jason-ha

I like it but I think some changes are not yet ready to be made.

package.json

jason-ha · 2026-03-20T22:21:24Z

common/build/eslint-config-fluid/README.md

@@ -103,7 +103,6 @@ a diff to review as part of a PR -- just like we do with API reports for code ch
 |--------|-------------|
 | `build` | `npm run print-config` |


pre-existing: build does npm run print-configs && npm run prettier

packages/framework/tree-agent-langchain/package.json

tools/pipelines/build-client.yml

tools/pipelines/build-eslint-config-fluid.yml

jason-ha · 2026-03-20T22:39:43Z

package.json

 		],
 		"overrides": {
+			"@biomejs/biome": "~2.4.5",
+			"@fluidframework/eslint-config-fluid": "link:common/build/eslint-config-fluid",


Does this need to be an override? Why can't we just have this in the catalog settings?
Bonus: you'll be able to make better comments there.

Because catalogs weren't in when I made this PR over a month ago. I'm just trying to get it merged ASAP.

ERR_PNPM_CATALOG_ENTRY_INVALID_SPEC The entry for '@fluidframework/eslint-config-fluid' in catalog 'eslint' declares a dependency using the 'link' protocol. This is not yet supported, but may be in a future version of pnpm.

Comments would be nice - not a blocker

syncpack.config.cjs

jason-ha · 2026-03-20T22:46:29Z

pnpm-lock.yaml

I feel like this might mess with Component Governance - there will be installs that are not in the lockfile.
Assuming this is just a transition step, then okay!

I don't follow. What is not covered by the root and eslint-config-fluid lockfiles?

It is probably fine. The root lockfile no longer represents the entirety of dependencies that the client workspace has. I would hope that all installs for a job are checked - but it feels like there could be missing association.

If I understood this correctly, the concern about the deps in eslint-config-fluid not being represented in the root lockfile is valid but the infra/tooling should still protect us. The install of eslint-config-fluid's deps should (right?) follow the lockfile in that folder, and all lockfiles in the repo are scanned during the Component Governance check. (For better and for worse; I'm not a fan of how we need to run all pipelines after updating the root lockfile, or one of the server lockfiles, so all pipelines declare a given alert resolved).

pnpm-workspace.yaml

common/build/eslint-config-fluid/package.json

jason-ha

two notes holding up me approving...

package.json

pnpm-workspace.yaml

syncpack.config.cjs

jason-ha · 2026-03-22T18:07:49Z

package.json

 		],
 		"overrides": {
+			"@biomejs/biome": "~2.4.5",
+			"@fluidframework/eslint-config-fluid": "link:common/build/eslint-config-fluid",


Comments would be nice - not a blocker

jason-ha · 2026-03-22T18:12:02Z

Something in build wants to change the README. Not sure why client build found that versus eslint-config-fluid build.

The auto-generated PACKAGE_SCRIPTS section was missing the `clean` script, causing the CI "Check for extraneous modified files" step to fail when markdown-magic regenerated it during the build.

The pnpm override still resolves to the local link: during development. Using the catalog entry is cleaner and aligns with the pattern used for other shared dependencies.

github-actions · 2026-03-24T23:37:49Z

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  272172 links
    1863 destination URLs
    2108 URLs ignored
       0 warnings
       0 errors

Copilot AI review requested due to automatic review settings February 12, 2026 02:27

Copilot started reviewing on behalf of tylerbutler February 12, 2026 02:28 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

syncpack.config.cjs Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

tylerbutler self-assigned this Feb 20, 2026

tylerbutler force-pushed the eslint-return-solo branch from f471425 to 098813a Compare February 23, 2026 17:43

tylerbutler requested a review from a team February 26, 2026 17:29

alexvy86 reviewed Feb 26, 2026

View reviewed changes

examples/apps/blobs/package.json Show resolved Hide resolved

common/build/eslint-config-fluid/package.json Show resolved Hide resolved

fluidBuild.config.cjs Show resolved Hide resolved

package.json Show resolved Hide resolved

tylerbutler requested review from a team as code owners March 10, 2026 21:44

move eslint out

aa6a972

tylerbutler force-pushed the eslint-return-solo branch from 3552a45 to aa6a972 Compare March 11, 2026 19:04

catalogs

126daaa

alexvy86 reviewed Mar 11, 2026

View reviewed changes

pnpm-lock.yaml Show resolved Hide resolved

tylerbutler changed the title ~~build(eslint-config-fluid): move back to independent workspace~~ build(eslint-config-fluid): restore as independent workspace Mar 11, 2026

tylerbutler requested a review from a team March 11, 2026 20:05

tylerbutler added 9 commits March 11, 2026 13:06

fix: address PR feedback

e1bc7e6

Add comment for npm-package-types-field exclusion and use pnpm -C with --frozen-lockfile for postinstall.

merge: integrate main into eslint-return-solo

4888255

Resolve merge conflict in package.json keeping both install:agency and postinstall scripts.

policy

d81f999

Merge branch 'main' into eslint-return-solo

7fc4f06

merge: resolve conflicts from main integration

75f6eb7

Updated build-tools to 0.64.0, kept eslint catalog and version 9.0.0 with private flag from main.

fix: remove private flag from eslint-config-fluid

b091e1c

The package needs to be published, so it should not be marked private.

Merge branch 'main' into eslint-return-solo

831f4b6

Merge branch 'main' into eslint-return-solo

295fe68

lockfile

38935af

jason-ha reviewed Mar 20, 2026

View reviewed changes

package.json Show resolved Hide resolved

tylerbutler commented Mar 20, 2026

View reviewed changes

package.json Outdated Show resolved Hide resolved

Apply suggestion from @tylerbutler

5f81635

jason-ha reviewed Mar 20, 2026

View reviewed changes

ChumpChief reviewed Mar 20, 2026

View reviewed changes

pnpm-workspace.yaml Show resolved Hide resolved

common/build/eslint-config-fluid/package.json Show resolved Hide resolved

Merge branch 'main' into eslint-return-solo

a8eb878

tylerbutler added 4 commits March 20, 2026 16:29

clean script

bc65f3b

fix syntax

b609990

revert

08eb83f

feedback

c0f5842

jason-ha reviewed Mar 22, 2026

View reviewed changes

tylerbutler added 7 commits March 23, 2026 14:24

Merge branch 'main' into eslint-return-solo

8047128

fix(eslint-config-fluid): regenerate README with current package scripts

3621049

The auto-generated PACKAGE_SCRIPTS section was missing the `clean` script, causing the CI "Check for extraneous modified files" step to fail when markdown-magic regenerated it during the build.

feedback

4b5f896

Merge branch 'main' into eslint-return-solo

9e6ebc1

lockfile

c232c4c

Merge branch 'main' into eslint-return-solo

78742c0

refactor: use catalog:eslint for eslint-config-fluid devDependency

e2f679d

The pnpm override still resolves to the local link: during development. Using the catalog entry is cleaner and aligns with the pattern used for other shared dependencies.

jason-ha approved these changes Mar 24, 2026

View reviewed changes

tylerbutler enabled auto-merge (squash) March 24, 2026 23:58

tylerbutler merged commit dabfc53 into microsoft:main Mar 25, 2026
56 checks passed

tylerbutler deleted the eslint-return-solo branch March 25, 2026 00:10

		@@ -103,7 +103,6 @@ a diff to review as part of a PR -- just like we do with API reports for code ch
		\|--------\|-------------\|
		\| `build` \| `npm run print-config` \|

Conversation

tylerbutler commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jason-ha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jason-ha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jason-ha commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2026

linkcheck output

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tylerbutler commented Feb 12, 2026 •

edited

Loading

jason-ha commented Mar 22, 2026 •

edited

Loading