-
Notifications
You must be signed in to change notification settings - Fork 371
fix: merging dev changes to main branch #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: Added changes in readme file related to SFI
chore: add environment variables to Bicep for local development setup
docs: down merge from main to dev
docs: updated env in readme local setup
docs: make deployment regions user-selectable in CustomizingAzdParameters.md
docs: updated env in readme local setup
fix: unit test fixing
fix: Differentiate between setup and processing errors
docs: removed local deployment file – content duplicated in DeploymentGuide
Prajwal-Microsoft
approved these changes
Aug 19, 2025
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Documentation improvements:
DeploymentGuide.md
andLocalDeployment.md
to clarify that the.env
file should be created in thesrc/backend
directory, and added instructions for automatically generating this file when usingazd
. Also, emphasized settingAPP_ENV
to "dev" and provided clearer guidance on populating environment variables. [1] [2]npm install
andnpm run build
insrc/frontend
) before running the application, ensuring necessary assets are generated. [1] [2]macae-dev.bicep
to the newinfra/main.bicep
deployment file, and clarified related instructions and role assignments. [1] [2] [3]Infrastructure and parameterization:
azureopenaiVersion
parameter ininfra/main.bicep
(default:'2025-01-01-preview'
), and updated the container app module to use this parameter, improving flexibility for API versioning. [1] [2]infra/main.bicep
for key resource connection strings, endpoints, and deployment names, making it easier to configure the application and automate environment variable setup.Parameter documentation:
AZURE_LOCATION
andAZURE_ENV_OPENAI_LOCATION
inCustomizingAzdParameters.md
from hardcoded regions to user-selected values during deployment, clarifying that these are now interactive inputs.General terminology updates:
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information