Skip to content

Conversation

@Dhruvkumar-Microsoft
Copy link
Contributor

Purpose

This pull request updates the configuration for the searchService module in both infra/main.bicep and infra/main_custom.bicep. The main changes involve enabling public network access and disabling private endpoint configuration for the search service, regardless of the value of enablePrivateNetworking.

Networking configuration changes:

  • Public network access for searchService is now always enabled by setting publicNetworkAccess: 'Enabled', and the previous conditional logic based on enablePrivateNetworking is commented out. (infra/main.bicep, [1]; infra/main_custom.bicep, [2]
  • The privateEndpoints property is now set to an empty array, effectively disabling private endpoint creation for the search service. The previous conditional private endpoint configuration is commented out. (infra/main.bicep, [1]; infra/main_custom.bicep, [2]

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 407b9cb into dev-v3 Sep 23, 2025
3 of 4 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-searchserviceissue branch September 23, 2025 06:08
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants