fix: enabled the public access for search service #522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the configuration for the
searchServicemodule in bothinfra/main.bicepandinfra/main_custom.bicep. The main changes involve enabling public network access and disabling private endpoint configuration for the search service, regardless of the value ofenablePrivateNetworking.Networking configuration changes:
searchServiceis now always enabled by settingpublicNetworkAccess: 'Enabled', and the previous conditional logic based onenablePrivateNetworkingis commented out. (infra/main.bicep, [1];infra/main_custom.bicep, [2]privateEndpointsproperty is now set to an empty array, effectively disabling private endpoint creation for the search service. The previous conditional private endpoint configuration is commented out. (infra/main.bicep, [1];infra/main_custom.bicep, [2]Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information