Skip to content

fix: enabled the public access for search service #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

fix: enabled the public access for search service #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ef6f01
enabled the public access for search service
Dhruvkumar-Microsoft Sep 23, 2025
ff1de98
added the comments
Dhruvkumar-Microsoft Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 26 additions & 18 deletions infra/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1921,7 +1921,11 @@ module searchService 'br/public:avm/res/search/search-service:0.11.1' = {
managedIdentities: {
systemAssigned: true
}
publicNetworkAccess: enablePrivateNetworking ? 'Disabled' : 'Enabled'

// Enabled the Public access because other services are not able to connect with search search AVM module when public access is disabled

// publicNetworkAccess: enablePrivateNetworking ? 'Disabled' : 'Enabled'
publicNetworkAccess: 'Enabled'
networkRuleSet: {
bypass: 'AzureServices'
}
Expand Down Expand Up @@ -1951,23 +1955,27 @@ module searchService 'br/public:avm/res/search/search-service:0.11.1' = {
principalType: 'ServicePrincipal'
}
]
privateEndpoints: enablePrivateNetworking
? [
{
name: 'pep-search-${solutionSuffix}'
customNetworkInterfaceName: 'nic-search-${solutionSuffix}'
privateDnsZoneGroup: {
privateDnsZoneGroupConfigs: [
{
privateDnsZoneResourceId: avmPrivateDnsZones[dnsZoneIndex.search]!.outputs.resourceId
}
]
}
subnetResourceId: virtualNetwork!.outputs.subnetResourceIds[0]
service: 'searchService'
}
]
: []

//Removing the Private endpoints as we are facing the issue with connecting to search service while comminicating with agents

privateEndpoints:[]
// privateEndpoints: enablePrivateNetworking
// ? [
// {
// name: 'pep-search-${solutionSuffix}'
// customNetworkInterfaceName: 'nic-search-${solutionSuffix}'
// privateDnsZoneGroup: {
// privateDnsZoneGroupConfigs: [
// {
// privateDnsZoneResourceId: avmPrivateDnsZones[dnsZoneIndex.search]!.outputs.resourceId
// }
// ]
// }
// subnetResourceId: virtualNetwork!.outputs.subnetResourceIds[0]
// service: 'searchService'
// }
// ]
// : []
}
}

Expand Down
44 changes: 26 additions & 18 deletions infra/main_custom.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1962,7 +1962,11 @@ module searchService 'br/public:avm/res/search/search-service:0.11.1' = {
managedIdentities: {
systemAssigned: true
}
publicNetworkAccess: enablePrivateNetworking ? 'Disabled' : 'Enabled'

// Enabled the Public access because other services are not able to connect with search search AVM module when public access is disabled

// publicNetworkAccess: enablePrivateNetworking ? 'Disabled' : 'Enabled'
publicNetworkAccess: 'Enabled'
networkRuleSet: {
bypass: 'AzureServices'
}
Expand Down Expand Up @@ -1992,23 +1996,27 @@ module searchService 'br/public:avm/res/search/search-service:0.11.1' = {
principalType: 'ServicePrincipal'
}
]
privateEndpoints: enablePrivateNetworking
? [
{
name: 'pep-search-${solutionSuffix}'
customNetworkInterfaceName: 'nic-search-${solutionSuffix}'
privateDnsZoneGroup: {
privateDnsZoneGroupConfigs: [
{
privateDnsZoneResourceId: avmPrivateDnsZones[dnsZoneIndex.search]!.outputs.resourceId
}
]
}
subnetResourceId: virtualNetwork!.outputs.subnetResourceIds[0]
service: 'searchService'
}
]
: []
privateEndpoints:[]

// Removing the Private endpoints as we are facing the issue with connecting to search service while comminicating with agents

// privateEndpoints: enablePrivateNetworking
// ? [
// {
// name: 'pep-search-${solutionSuffix}'
// customNetworkInterfaceName: 'nic-search-${solutionSuffix}'
// privateDnsZoneGroup: {
// privateDnsZoneGroupConfigs: [
// {
// privateDnsZoneResourceId: avmPrivateDnsZones[dnsZoneIndex.search]!.outputs.resourceId
// }
// ]
// }
// subnetResourceId: virtualNetwork!.outputs.subnetResourceIds[0]
// service: 'searchService'
// }
// ]
// : []
}
}

Expand Down
Loading