Remove circularity, rootDir errors from node modules compiler tests #62568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks microsoft/typescript-go#1797; the circularities in these tests don't appear to be required to test what the tests need to test. Rather, they were I think just a nice place to test imports of various kinds.
All of the tests were modified in the same way, splitting
index.d.ts
files like:Into two files:
To both declare a module, but do the import stuff in another place.
I ordered the files in the tests in a way that makes the diffs still try and compare apples-to-apples. so hopefully it shows that the types are still the same (though, sometimes named differently).
Also, drop
rootDir
errors from the tests by setting one manually.