Skip to content

prime95 fix #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

prime95 fix #555

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
95781a3
Waiting for prime95 process to exit.
Jul 24, 2025
facf4c2
Add a 5 second wait instead of waiting for the process to finish outr…
Jul 25, 2025
830ab2e
Merge branch 'main' into users/saibulusu/prime95-fix
saibulusu Jul 25, 2025
98cc471
Killing entire process tree instead of safe kill.
Jul 28, 2025
7697a83
Merge branch 'users/saibulusu/prime95-fix' of https://github.com/micr…
Jul 28, 2025
0192bdd
Merge branch 'main' into users/saibulusu/prime95-fix
saibulusu Jul 29, 2025
444db71
Merge branch 'main' into users/saibulusu/prime95-fix
saibulusu Jul 29, 2025
2040bea
Removing delay async from unit test.
Jul 29, 2025
670f384
Merge branch 'users/saibulusu/prime95-fix' of https://github.com/micr…
Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/VirtualClient/VirtualClient.Actions/Prime95/Prime95Executor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,8 @@ await this.Logger.LogMessageAsync($"{this.TypeName}.ExecuteWorkload", telemetryC
{
await this.WaitAsync(explicitTimeout, cancellationToken);
process.SafeKill();
// await process.WaitForExitAsync(cancellationToken);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this doesn't add delay to unit tests, if it does, find a way to mock it

await Task.Delay(5000); // Wait up to 5 seconds for the process to clean up

if (!cancellationToken.IsCancellationRequested)
{
Expand All @@ -302,7 +304,7 @@ await this.Logger.LogMessageAsync($"{this.TypeName}.ExecuteWorkload", telemetryC
{
results = await this.fileSystem.File.ReadAllTextAsync(this.ResultsFilePath);
}

if (string.IsNullOrWhiteSpace(results))
{
throw new WorkloadResultsException(
Expand Down
4 changes: 1 addition & 3 deletions website/docs/workloads/prime95/prime95.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ The following list describes the measurements captured by the workload running a

* Number of Tests passed.
* Number of Tests failed.
* Time-to-Compute the Tests (in seconds).

## Workload Metrics
The following metrics are examples of those captured by the Virtual Client when running the Prime95 workload.
Expand All @@ -54,5 +53,4 @@ for which the system was stressed with torture test. A higher the test time with
| Metric Name | Example Value (min) | Example Value (max) | Example Value (avg) | Unit |
|--------------|---------------------|---------------------|---------------------|------|
| failTestCount | 0.0 | 0.0 | 0.0 | |
| passTestCount | 32.0 | 192.0 | 115.45833333333333 | |
| testTime | 3600.0031989 | 3601.679443 | 3600.23347608125 | seconds |
| passTestCount | 32.0 | 192.0 | 115.45833333333333 | |
Loading