WSLA: Resolve issue preventing boot from pmem vhds #14036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a boot failure when using PMEM VHDs by preventing the HCS stack from applying a restrictive default max size. The issue occurred because setting pmemController.MaximumCount to a non-zero value triggered HCS to apply a default size limit that was too small for the new root VHD.
Key changes:
- Refactored PMEM controller initialization to use a separate
nextDeviceIdvariable instead ofMaximumCountfor device ID tracking - Re-enabled the previously skipped
PmemVhdstest that validates PMEM boot functionality
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/windows/wslaservice/exe/WSLAVirtualMachine.cpp |
Refactored PMEM controller to avoid setting MaximumCount, preventing HCS from applying default size limits |
test/windows/WSLATests.cpp |
Re-enabled PmemVhds test now that the underlying boot issue is resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue where a new root VHD stopped PMEM boot from working. This is because in the HCS stack there is a default max size that is applied when pmemController.MaximumCount != 0 and this max size was not large enough for the new VHD.